Filtering service uuids in parameters for startScanning() is not reliable. #18

Activity

1. pursual commented on Aug 31, 2020

   

   pursual

   on Aug 31, 2020

   Last edited by pursual

   Author

   More actions

   It looks like it works when the array only contains one item?

   This might be miscoded. Instead of matching any of the service uuids, it might be trying to match only advertisements which contain ALL of them. I do not have a device that broadcasts moret than 1 service uuid, so unable to confirm.

   Regardless it does not work with more than one service uuid. noble_uwp and other bindings do.
2. pursual

   changed the title [-]Does not accept service uuids to filter in parameters for startScanning() like other biindings?[/-] [+]Filtering service uuids in parameters for startScanning() is not reliable.[/+] on Aug 31, 2020
3. geovie commented on Sep 1, 2020

   

   geovie

   on Sep 1, 2020

   Contributor

   More actions

   @pursual You're right currently we pass the service uuids as filter to the AdvertismentWatcher.

   The alternative would be to watch for all and filter the advertisement manually once we receive it.

   If anyone wants to provide a PR for this the steps would be:

   • remove the advertisment filter https://github.com/Timeular/noble-winrt/blob/master/src/ble_manager.cc#L119-L127
   • save serviceUUIDs in a class field mAdvertiementServiceUUIDs (similar to mAllowDuplicates)
   • check if the received advertisement's serviceUUIDs contain any of the saved mAdvertiementServiceUUIDs https://github.com/Timeular/noble-winrt/blob/master/src/ble_manager.cc#L139
4. geovie

   added

   help wantedExtra attention is neededExtra attention is needed

   on Sep 1, 2020
5. tony-gutierrez commented on Oct 28, 2020

   

   tony-gutierrez

   on Oct 28, 2020

   Contributor

   More actions

   Fixed in https://github.com/tony-gutierrez/noble-winrt/tree/servicefilter which is based off of https://github.com/fido-alliance/noble-winrt