chore: update nimbus-ds packages to latest rc versions - #165
Open
noecondoleo wants to merge 15 commits into
Open
chore: update nimbus-ds packages to latest rc versions#165noecondoleo wants to merge 15 commits into
noecondoleo wants to merge 15 commits into
Conversation
- Menu background: neutral-background → neutral-surfaceHighlight - MenuButton hover bg: primary-surface → neutral-interactive - MenuButton active (pressed) bg: primary-surfaceHighlight → neutral-background - MenuButton selected (active prop) bg: primary-surface → neutral-background - menuInsideFixedBar story border: neutral-surfaceHighlight → neutral-interactive - Add @nimbus-ds/styles@9.62.1-rc.5, tokens@9.5.1-rc.5, components@5.57.2-rc.2 resolutions Made-with: Cursor
- @nimbus-ds/components 5.55.0 - @nimbus-ds/styles 9.62.1-rc.7 - @nimbus-ds/tokens 9.5.1-rc.6 Made-with: Cursor
…mic contentid - Rename tooltip references to popover in Menu tests and types - Restore Menu index exports to pre-existing pattern - Add dynamic contentid prop to MenuButtonAccordion replacing hardcoded id - Remove Menu changelog entry for 1.2.0
…orte UI white version - MenuButtonAccordion: active state background changed from primary-surface to neutral-surface - MenuButtonContent: active/xs background changed from neutral-background to neutral-surface - AppShellHeader: background updated from neutral-surface to neutral-surfaceDisabled - AppShell: content area background updated from neutral-surface to neutral-surfaceDisabled Made-with: Cursor
…xtHigh Update logo color from primary-interactive to neutral-textHigh in AppShell stories and Menu utils to match Norte UI white version design. Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
- @nimbus-ds/components 5.57.2-rc.5 → 5.57.3-rc.3 - @nimbus-ds/styles 9.62.1-rc.7 → 9.62.5-rc.1 - @nimbus-ds/tokens 9.5.1-rc.6 → 9.5.3-rc.2 Made-with: Cursor
- @nimbus-ds/components 5.57.3-rc.3 → 5.57.7-rc.1 - @nimbus-ds/styles 9.62.5-rc.1 → 9.62.7-rc.1 - @nimbus-ds/tokens 9.5.3-rc.2 → 9.5.3-rc.4 Made-with: Cursor
- @nimbus-ds/tokens: 9.5.3-rc.4 → 9.5.3-rc.5 - @nimbus-ds/styles: 9.62.7-rc.1 → 9.62.7-rc.2 - @nimbus-ds/components: 5.57.7-rc.1 → 5.57.7-rc.2 Made-with: Cursor
Contributor
Getting startedPlease make sure you read our documentation on how to write code for components, stories and styles.
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note
|
| Cohort / File(s) | Summary |
|---|---|
Workflow & Dependencies .github/workflows/publish-rc-manual.yml, package.json |
Added formatting whitespace to workflow file. Updated @nimbus-ds/components, @nimbus-ds/styles, and @nimbus-ds/tokens to RC versions and added Yarn resolutions to enforce these versions. |
AppShell Component Styling packages/react/src/components/AppShell/src/AppShell.tsx, packages/react/src/components/AppShell/src/appShell.stories.tsx, packages/react/src/components/AppShell/src/components/AppShellHeader/AppShellHeader.tsx |
Changed main content container and header background colors from neutral-surface to neutral-surfaceDisabled. Updated logo icon color in menu from primary-interactive to neutral-textHigh across expanded menu states. |
Menu Component Updates packages/react/src/components/Menu/src/Menu.tsx, packages/react/src/components/Menu/src/menu.stories.tsx, packages/react/src/components/Menu/src/menu.utils.tsx, packages/react/src/components/Menu/src/menu.spec.tsx, packages/react/src/components/Menu/CHANGELOG.md |
Changed container background from neutral-background to neutral-surfaceHighlight and story border color from neutral-surfaceHighlight to neutral-interactive. Updated logo icon color from primary-interactive to neutral-textHigh in expanded state. Renamed test descriptions from "tooltip" to "popover" terminology. Removed legacy changelog entry for version 1.2.0. |
MenuButton Component Type & Styling Updates packages/react/src/components/MenuButton/src/components/MenuButtonAccordion/MenuButtonAccordion.tsx, packages/react/src/components/MenuButton/src/components/MenuButtonAccordion/menuButtonAccordion.types.ts, packages/react/src/components/MenuButton/src/components/MenuButtonContent/MenuButtonContent.tsx |
Added contentid prop to MenuButtonAccordion to replace hard-coded content ID. Changed MenuButtonAccordion active state background from primary-surface to neutral-surface. Updated MenuButtonAccordionBaseProps type to omit showPopoversWhenCollapsed instead of tooltipText. Replaced primary-* palette values with neutral-* equivalents in MenuButtonContent state mappings. |
ProductUpdates Component Refactoring packages/react/src/components/ProductUpdates/src/components/ProductUpdatesFooter/ProductUpdatesFooter.tsx |
Simplified Divider rendering by removing explicit styling props and relying on defaults. |
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested labels
dependencies
Important
Pre-merge checks failed
Please resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (2 errors, 1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Unversioned Breaking Changes | ❌ Error | Pull request introduces two breaking API changes to MenuButton component: required contentid prop and changed omitted props from tooltipText to showPopoversWhenCollapsed, but version remains at 2.0.3 instead of 3.0.0. | Update package.json to version 3.0.0 to align with semantic versioning for breaking changes, or make contentid optional and allow both props to maintain backward compatibility. |
| Breaking Change Documentation Verification | ❌ Error | PR introduces breaking changes (required contentid prop, type modifications) but root CHANGELOG.md lacks a documented '#### 🛠 Breaking changes' section for PR #165. |
Add '#### 🛠 Breaking changes' section to root CHANGELOG.md documenting the required contentid prop addition, MenuButtonAccordionBaseProps type change, and color token updates with migration guidance and PR #165 reference. |
| Title check | The title follows the required format 'chore: ...' but lacks the required '(PackageName)' component. | Update the title to include the package scope, e.g., 'chore(nimbus-ds): update packages to latest rc versions' to fully comply with the format requirements. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Commit unit tests in branch
PruebasNorteUI
Comment @coderabbitai help to get the list of available commands and usage tips.
coderabbitai
Bot
added
the
dependencies
Made-with: Cursor
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@packages/react/src/components/MenuButton/src/components/MenuButtonAccordion/MenuButtonAccordion.tsx`:
- Line 25: The MenuButton trigger is not wired to the panel via
aria-controls—add aria-controls={contentid} to the MenuButton/trigger element so
the trigger references the panel id (contentid) for correct ARIA mapping; locate
where MenuButton is rendered (the trigger element in MenuButtonAccordion /
component that receives contentid) and pass contentid into the trigger as
aria-controls, ensuring the panel retains id={contentid} and no other prop names
are changed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 6d0957a0-0a62-479f-bc87-ef3c8bf409eb
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock,!**/*.lock
📒 Files selected for processing (14)
.github/workflows/publish-rc-manual.ymlpackage.jsonpackages/react/src/components/AppShell/src/AppShell.tsxpackages/react/src/components/AppShell/src/appShell.stories.tsxpackages/react/src/components/AppShell/src/components/AppShellHeader/AppShellHeader.tsxpackages/react/src/components/Menu/CHANGELOG.mdpackages/react/src/components/Menu/src/Menu.tsxpackages/react/src/components/Menu/src/menu.spec.tsxpackages/react/src/components/Menu/src/menu.stories.tsxpackages/react/src/components/Menu/src/menu.utils.tsxpackages/react/src/components/MenuButton/src/components/MenuButtonAccordion/MenuButtonAccordion.tsxpackages/react/src/components/MenuButton/src/components/MenuButtonAccordion/menuButtonAccordion.types.tspackages/react/src/components/MenuButton/src/components/MenuButtonContent/MenuButtonContent.tsxpackages/react/src/components/ProductUpdates/src/components/ProductUpdatesFooter/ProductUpdatesFooter.tsx
💤 Files with no reviewable changes (1)
- packages/react/src/components/Menu/CHANGELOG.md
| children, | ||
| as, | ||
| expanded: expandedProp, | ||
| contentid, |
Contributor
There was a problem hiding this comment.
Wire contentid to the trigger via aria-controls for complete accordion accessibility.
id={contentid} on the panel is good, but the trigger still lacks the explicit relationship to that panel. Add aria-controls on MenuButton so assistive tech can map control-to-content reliably.
♿ Proposed fix
<MenuButton
{...menuButton}
onClick={
controlledOpen !== undefined ? menuButton.onClick : handleOpen
}
active={active}
aria-expanded={open && expanded}
+ aria-controls={open && expanded ? contentid : undefined}
showPopoversWhenCollapsed={false}
expanded={expanded}
/>As per coding guidelines, "Implement proper ARIA attributes in React components" and "Follow WCAG 2.1 guidelines for accessibility compliance in React components".
Also applies to: 95-95
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@packages/react/src/components/MenuButton/src/components/MenuButtonAccordion/MenuButtonAccordion.tsx`
at line 25, The MenuButton trigger is not wired to the panel via
aria-controls—add aria-controls={contentid} to the MenuButton/trigger element so
the trigger references the panel id (contentid) for correct ARIA mapping; locate
where MenuButton is rendered (the trigger element in MenuButtonAccordion /
component that receives contentid) and pass contentid into the trigger as
aria-controls, ensuring the panel retains id={contentid} and no other prop names
are changed.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 223 223
Lines 1743 1743
Branches 358 358
=======================================
Hits 1625 1625
Misses 113 113
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- hover: neutral-interactive → neutral-interactiveLow - pressed: neutral-surface → neutral-interactive - update nimbus-ds packages to latest rc versions (rc.4/rc.7) Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
|
Contributor
|
🚀✨ Your Storybook preview is ready! Happy reviewing! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@nimbus-ds/tokensfrom9.5.3-rc.4to9.5.3-rc.5@nimbus-ds/stylesfrom9.62.7-rc.1to9.62.7-rc.2@nimbus-ds/componentsfrom5.57.7-rc.1to5.57.7-rc.2Summary by CodeRabbit
New Features
MenuButtonAccordionnow supports customizable content identification for improved accessibility.Style
Dividerrendering in product updates footer to use default styling.Tests