Drop coveragerecords and equivalentscoveragerecords tables (PP-4653)

[dbernstein]

Description

Stacked follow-up to #3503 ("Retire the CoverageProvider machinery"). Now that no running code reads or writes the coverage tables, this PR removes the CoverageRecord and (already-dormant) EquivalencyCoverageRecord models, the coverage_records relationships on Identifier/DataSource/Collection, and drops the coveragerecords and equivalentscoveragerecords tables along with their shared coverage_status enum.

Timestamp, its separate service_type enum, and the BaseCoverageRecord mixin (still imported by the workcoveragerecords-removal migration for status_enum) are retained.

Motivation and Context

JIRA (PP-4653)
This is the "release 2" half of the CoverageProvider retirement. Per the online-migration / N-1 rule, the tables could not be dropped in the same release that stopped using them (#3503) — N-1 app servers still wrote to them during a rolling deploy.

⚠️ Draft until the release containing #3503 has shipped. Merging earlier would break N-1 webservers that still write to these tables.

How Has This Been Tested?

• mypy and ruff pass on all changed files.
• The migration round-trips on a real Postgres: upgrade drops both tables and the coverage_status enum (leaving timestamps / service_type intact); downgrade recreates both tables with identical indexes, constraints, and foreign keys; a second upgrade drops them again.
• The full tests/migration/ suite passes under tox -e py312-docker (incl. pytest-alembic single-head / up-down-consistency / model-matches-DDL checks and a new drop test), along with the Timestamp, collection-deletion, identifier, and data-layer apply tests.

Checklist

• I have updated the documentation accordingly.
• All new and existing tests passed.

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

This is the "Release 2" cleanup of the CoverageProvider retirement: it drops the coveragerecords and equivalentscoveragerecords tables and their shared coverage_status Postgres enum, removes the CoverageRecord/EquivalencyCoverageRecord SQLAlchemy models, deletes core/coverage.py and the coverage provider scripts, and strips all coverage_records relationships from Identifier/DataSource/Collection. BaseCoverageRecord and Timestamp are intentionally kept because the existing workcoveragerecords-removal migration still imports status_enum from BaseCoverageRecord.

• Migration (20260624_5ca948100902) correctly drops indexes → tables → enum in upgrade, and reverses in downgrade with manual create_type=False lifecycle management; the checkfirst=False flag is intentional.
• Overdrive API replaces the retired OverdriveBibliographicCoverageProvider with an inline _ensure_bibliographic_coverage helper that fetches metadata, applies it to the edition, and sets the work presentation-ready — preserving the old behavior without the coverage-record side effect.
• refresh_metadata admin endpoint now unconditionally returns METADATA_REFRESH_FAILURE (no provider is wired up); the docstring and updated test explicitly document this intentional behavioral stub.

Confidence Score: 4/5

Safe to merge once the release containing #3503 has shipped; the draft guard in the PR description is the only merge blocker.

The change is a well-scoped cleanup: dead tables are dropped in the correct release slot per the N-1 convention, all code references to the removed models have been cleaned up, and the migration round-trips correctly. The only finding is a stale one-liner docstring on BaseCoverageRecord that still mentions the now-deleted CoverageRecord class.

src/palace/manager/sqlalchemy/model/coverage.py — stale docstring on BaseCoverageRecord; all other files look clean.

Important Files Changed

Filename	Overview
alembic/versions/20260624_5ca948100902_drop_coveragerecords_and_.py	New migration that drops coveragerecords, equivalentscoveragerecords, and the coverage_status enum; downgrade recreates all three. create_type=False and checkfirst=False are correctly paired; enum lifecycle is manually managed.
src/palace/manager/sqlalchemy/model/coverage.py	Removed CoverageRecord and EquivalencyCoverageRecord models; retained BaseCoverageRecord (needed by the workcoveragerecords migration) and Timestamp. Minor stale docstring on BaseCoverageRecord.
src/palace/manager/integration/license/overdrive/api.py	Replaced OverdriveBibliographicCoverageProvider.ensure_coverage call with a new inline _ensure_bibliographic_coverage method; correctly fetches metadata, applies to edition, and sets work presentation-ready.
src/palace/manager/api/admin/controller/work_editor.py	refresh_metadata now always returns METADATA_REFRESH_FAILURE; provider parameter removed; behavior is intentional and documented in the updated docstring.
src/palace/manager/data_layer/bibliographic.py	Removed create_coverage_record parameter from BibliographicData.apply and the CoverageRecord.add_for call inside it.
src/palace/manager/core/coverage.py	Entire file deleted; all CoverageProvider classes (BaseCoverageProvider, IdentifierCoverageProvider, CollectionCoverageProvider, BibliographicCoverageProvider, CoverageFailure) removed along with the module.
tests/migration/test_20260624_5ca948100902_drop_coverage_tables.py	New migration test that steps down one revision, verifies both tables exist, then steps back up and verifies they are dropped while timestamps remains.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant OD as OverdriveAPI
    participant ECB as _ensure_bibliographic_coverage (new)
    participant ME as metadata_lookup
    participant ORE as OverdriveRepresentationExtractor
    participant BD as BibliographicData.apply
    participant LP as LicensePool

    OD->>OD: update_licensepool()
    OD->>ECB: _ensure_bibliographic_coverage(license_pool)
    ECB->>ME: metadata_lookup(identifier)
    ME-->>ECB: info dict
    alt errorCode in (NotFound, InvalidGuid)
        ECB-->>OD: return (log warning)
    else
        ECB->>ORE: book_info_to_bibliographic(info)
        ORE-->>ECB: BibliographicData
        ECB->>BD: apply(db, edition, collection, replace)
        BD-->>ECB: (edition, changed)
        alt work missing or not presentation_ready
            ECB->>LP: calculate_work()
            LP-->>ECB: work
            ECB->>LP: work.set_presentation_ready()
        end
    end
    ECB-->>OD: return

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant OD as OverdriveAPI
    participant ECB as _ensure_bibliographic_coverage (new)
    participant ME as metadata_lookup
    participant ORE as OverdriveRepresentationExtractor
    participant BD as BibliographicData.apply
    participant LP as LicensePool

    OD->>OD: update_licensepool()
    OD->>ECB: _ensure_bibliographic_coverage(license_pool)
    ECB->>ME: metadata_lookup(identifier)
    ME-->>ECB: info dict
    alt errorCode in (NotFound, InvalidGuid)
        ECB-->>OD: return (log warning)
    else
        ECB->>ORE: book_info_to_bibliographic(info)
        ORE-->>ECB: BibliographicData
        ECB->>BD: apply(db, edition, collection, replace)
        BD-->>ECB: (edition, changed)
        alt work missing or not presentation_ready
            ECB->>LP: calculate_work()
            LP-->>ECB: work
            ECB->>LP: work.set_presentation_ready()
        end
    end
    ECB-->>OD: return

Loading

Comments Outside Diff (1)

1. src/palace/manager/sqlalchemy/model/coverage.py, line 33-34 (link)

   The class docstring still references CoverageRecord, which no longer exists after this PR removes the model.

   Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

_{Reviews (1): Last reviewed commit: "Drop coveragerecords and equivalentscove..." | Re-trigger Greptile}

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.56%. Comparing base (79681e2) to head (95ebc82).

Files with missing lines	Patch %	Lines
...alace/manager/integration/license/overdrive/api.py	58.82%	5 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3504      +/-   ##
==========================================
+ Coverage   93.48%   93.56%   +0.07%     
==========================================
  Files         511      508       -3     
  Lines       46570    45808     -762     
  Branches     6339     6221     -118     
==========================================
- Hits        43538    42860     -678     
+ Misses       1968     1913      -55     
+ Partials     1064     1035      -29     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dbernstein]

Superseded by #3521, which moves this branch to an upstream branch stacked on #3520 (and additionally removes the now-orphaned BaseCoverageRecord mixin).