[FIX] devel-setup: drop networks, it conflicts with network_mode

[rrebollo]

Correction

My first report said this breaks invoke git-aggregate. That was wrong.

docker compose run <service> does not validate the project the way docker compose config does, so the workflow is unaffected — which is what you found, and what
tests/test_downstream_tasks.py already keeps covered. I had run docker compose config without --profile, seen exit 0, and concluded the service was valid.

What does hold is that the service is invalid for anything that validates the project
with the profile on. On Engine 29.8.1 / Compose 5.5.1:

$ docker compose config                          # exit 0, devel-setup excluded
$ docker compose --profile devel-setup config     # exit 1
service devel-setup declares mutually exclusive `network_mode` and `networks`

devel-setup extends odoo, which carries network_mode: service:gatekeeper since
6bfc5b6, and declares network_mode: host. A service may not also declare networks,
and with network_mode: host no compose network applies, so the line was inert.

Fix

Drop the two lines. No test — you're right that test_downstream_tasks.py covers it.

[david-banon-tecnativa]

Hi, i can't replicate the issue on Doodba copier template. While the original issue of networks and network mode not coexisting on a container is indeed real, and the isolated example raises an issue, I can run invoke git-aggregate just fine on any template v10+ project.
What docker and docker compose versions are you running?

[rrebollo]

Thanks — both points applied: description corrected, test removed.

Engine 29.8.1, Compose 5.5.1, Linux Mint 22.3, kernel 6.8.0-142.

On why you couldn't reproduce it: docker compose run <service> doesn't validate the project the way docker compose config does. invoke git-aggregate works here too, and test_downstream_tasks.py covers it as you said. Only docker compose --profile devel-setup config fails.

You're also right that the service is genuinely invalid — that part of the original report stands. Happy to close this instead if you'd rather not carry a 2-line cleanup with no symptom behind it.

[pedrobaeza]

Wasn't it red?

[david-banon-tecnativa]

Test failure was unrelated, Tecnativa/doodba#737