Skip to content

Adjust AnalyzeClasses annotation to support individual classes as parameter - #1569

Merged
TheManWhoStaresAtCode merged 1 commit into
mainfrom
1195_analyze_list_of_classes
Jul 30, 2026
Merged

Adjust AnalyzeClasses annotation to support individual classes as parameter#1569
TheManWhoStaresAtCode merged 1 commit into
mainfrom
1195_analyze_list_of_classes

Conversation

@TheManWhoStaresAtCode

Copy link
Copy Markdown
Member

As suggested in the ticket adjust the annotation to have a new classes property to select individual classes as an additional option.

Resolves #1195

@TheManWhoStaresAtCode
TheManWhoStaresAtCode force-pushed the 1195_analyze_list_of_classes branch from 11e740b to f6a08b9 Compare December 28, 2025 22:02

@StefanGraeber StefanGraeber left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some comment and naming updates I'd prefer

@StefanGraeber StefanGraeber left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase and cleanup the commits in the end. it's currently really hard to follow with merging old branches

the only blocking issue for me is now the overlapping testdata effectively skipping one assertion

@StefanGraeber StefanGraeber left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
please cleanup the git history before merging
(commit messages like "implement review comments" should not survive in the end ;)

@TheManWhoStaresAtCode
TheManWhoStaresAtCode force-pushed the 1195_analyze_list_of_classes branch from beb48c7 to b811bbb Compare July 27, 2026 21:00
@TheManWhoStaresAtCode
TheManWhoStaresAtCode force-pushed the 1195_analyze_list_of_classes branch 2 times, most recently from 37fc07d to e1813ca Compare July 28, 2026 21:51
…ameter

* in case several AnalyzeClasses properties are defined the result is the union of all derived classes. Verify and document this behavior.

Relates to #1195

Signed-off-by: Andreas Zöller <andreas.zoeller@tngtech.com>
@StefanGraeber
StefanGraeber force-pushed the 1195_analyze_list_of_classes branch from e1813ca to d95f0ae Compare July 30, 2026 19:39
@TheManWhoStaresAtCode
TheManWhoStaresAtCode merged commit c024f52 into main Jul 30, 2026
62 of 63 checks passed
@TheManWhoStaresAtCode
TheManWhoStaresAtCode deleted the 1195_analyze_list_of_classes branch July 30, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support to analyse list of classes

2 participants