Skip to content

Add critic load fallback for resuming training #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coding-famer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add critic load fallback for resuming training #2200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions slime/utils/arguments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1623,6 +1623,20 @@ def _apply_megatron_role_overrides(base_args, overrides, role):
if "disable_param_buffers_cpu_backup" not in overrides:
role_args.disable_param_buffers_cpu_backup = False

# If the critic's own load has no checkpoint yet, fall back to the
# actor's resolved load.
critic_load = role_args.load
if (
critic_load is None
or not os.path.exists(critic_load)
or not os.path.exists(os.path.join(critic_load, "latest_checkpointed_iteration.txt"))
):
role_args.load = base_args.load
role_args.no_load_optim = True
role_args.no_load_rng = True
role_args.finetune = True
role_args.start_rollout_id = 0

return role_args


Expand Down
Loading