Skip to content

[#14346] Redirect with back-end configured frontendUrl#14347

Open
TobyCyan wants to merge 19 commits into
TEAMMATES:masterfrom
TobyCyan:redirect-frontend-url
Open

[#14346] Redirect with back-end configured frontendUrl#14347
TobyCyan wants to merge 19 commits into
TEAMMATES:masterfrom
TobyCyan:redirect-frontend-url

Conversation

@TobyCyan

@TobyCyan TobyCyan commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Fixes #14346

Outline of Solution

  • Step 2 of the issue.

@TobyCyan TobyCyan changed the title [#14346] Redirect frontend url [#14346] Redirect with back-end configured frontendUrl Jun 25, 2026
@TobyCyan
TobyCyan marked this pull request as ready for review June 26, 2026 08:58
@samuelfangjw

Copy link
Copy Markdown
Member
  • This PR also sets the E2E and Axe CI jobs to redirect to port 8080 for frontend URL.

@TobyCyan, help to do a check on this. Why is there a need to set a different frontend and backend url for tests? Can we just follow the actual backend configuration instead? Keep in mind the e2e suite only works properly in dev env at the moment and there are no plans to have it support running against a live server in the future.

Comment thread src/main/java/teammates/common/util/UrlHelper.java
@TobyCyan

TobyCyan commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author
  • This PR also sets the E2E and Axe CI jobs to redirect to port 8080 for frontend URL.

@TobyCyan, help to do a check on this. Why is there a need to set a different frontend and backend url for tests? Can we just follow the actual backend configuration instead? Keep in mind the e2e suite only works properly in dev env at the moment and there are no plans to have it support running against a live server in the future.

There is an architectural rule that says the E2E package shouldn't reference Config properties. I suppose it's to keep between test-only configs independent from app configs. However, I think we could have BaseE2ETestCase reference the Config URLs since the servlets' redirection behavior is determined by Config.

@TobyCyan
TobyCyan marked this pull request as draft July 8, 2026 02:56
@TobyCyan
TobyCyan marked this pull request as ready for review July 10, 2026 01:49
@TobyCyan
TobyCyan requested a review from samuelfangjw July 10, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use back-end as the source of truth for frontend URL configuration

2 participants