Fix center-80 window preset sizing - #640
Open
YuriNachos wants to merge 1 commit into
Open
Conversation
The center-80 preset ('Almost Maximize') computed the target frame with the wrong multiplier, so the window was not sized to 80% of the screen as intended. Correct the size computation to 80% of the usable screen area.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
center-80preset (UI label "Almost Maximize") now sizes the window to 80% of the usable screen, matching its name. Today it used a 0.9 (90%) multiplier.Root cause
window-adjust.swiftused0.9for thecenter80case — a copy/paste or misnamed constant — so the window was 90% of the screen, not the intended 80%.Changes
src/native/window-adjust.swift—0.9→0.8for both width and height in the.center80case (2 lines).scripts/test-window-adjust-center80.mjs— asserts the resulting frame is 80% of a known area.This change was developed with AI assistance (Claude Code); every changed line was reviewed and understood.