[BugFix] Fix bRPC stub cache clean timer leak (backport #75973)#76360
Closed
mergify[bot] wants to merge 1 commit into
Closed
[BugFix] Fix bRPC stub cache clean timer leak (backport #75973)#76360mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
Signed-off-by: kaijian.ding <kaijian.ding@gmail.com> Co-authored-by: wanpengfei-git <wanpengfei91@163.com> (cherry picked from commit 2bbca67) # Conflicts: # be/src/util/brpc_stub_cache.cpp # be/src/util/brpc_stub_cache.h # be/test/util/brpc_stub_cache_test.cpp
Contributor
Author
|
Cherry-pick of 2bbca67 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
wanpengfei-git
enabled auto-merge (squash)
July 14, 2026 12:06
23 tasks
auto-merge was automatically disabled
July 14, 2026 12:06
Pull request was closed
Contributor
Author
|
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
there is mem leak caused by bRPC stub cache clean timer leak due to timer is unscheduled but not removed from mem.
every
get_stub()will do_timer->unschedule()and_timer->schedule().unlike what we expect,
_timer->unschedule()will not remove internal objects, thus leak happensWhat I'm doing:
extend timer deadline if the stub is still in use instead of
unschedule()Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #75973 done by [Mergify](https://mergify.com).