Skip to content

Fix duplicated menu with changed identifier throws an error if same submenu template does not exist #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manan-patel1 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix duplicated menu with changed identifier throws an error if same submenu template does not exist #416

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05638be
Fix duplicated menu with changed identifier throws an error if same s…
manan-patel1 Sep 7, 2026
224e10a
Use TemplateResolver::getMenuTemplate() to cache submenu template loo…
manan-patel1 Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Block/Menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,9 +445,15 @@ private function getSubmenuBlock($nodes, $parentNode, $level = 0)
{
$block = clone $this;
$submenuTemplate = $parentNode->getSubmenuTemplate();
$submenuTemplate = $submenuTemplate
? 'Snowdog_Menu::' . $this->getMenu()->getIdentifier() . "/menu/custom/sub_menu/{$submenuTemplate}.phtml"
: $this->submenuTemplate;

if ($submenuTemplate) {
$customSubmenuTemplate = 'Snowdog_Menu::' . $this->getMenu()->getIdentifier() . "/menu/custom/sub_menu/{$submenuTemplate}.phtml";
$submenuTemplate = $this->templateResolver->isValidTemplate($block, $customSubmenuTemplate)

@jupiterlewis jupiterlewis Sep 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manan-patel1 isValidTemplate does a filesystem call. Since this is running for every submenu item, the validity should be cached. Take a look at Model/TemplateResolver.php getMenuTemplate(). Check if you can use that instead.

? $customSubmenuTemplate
: $this->submenuTemplate;
} else {
$submenuTemplate = $this->submenuTemplate;
}

$block->setSubmenuNodes($nodes)
->setParentNode($parentNode)
Expand Down
10 changes: 10 additions & 0 deletions Model/TemplateResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,16 @@ public function getMenuTemplate($block, $menuId, $template, $nodeId = null)
return $this->setTemplateMap($menuId, $newTemplate, $template, $nodeId);
}

/**
* @param Template $block
* @param string $template
* @return bool
*/
public function isValidTemplate($block, $template)
{
return (bool) $this->validator->isValid($block->getTemplateFile($template));
}

/**
* @param string $nodeType
* @param string $defaultTemplateLabel
Expand Down