Skip to content

Fix addUser() -> addCredential() issue - #3220

Merged
HunsupJung merged 1 commit into
mainfrom
fix/add-user-and-add-credential
Sep 11, 2026
Merged

Fix addUser() -> addCredential() issue#3220
HunsupJung merged 1 commit into
mainfrom
fix/add-user-and-add-credential

Conversation

@HunsupJung

@HunsupJung HunsupJung commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

https://smartthings.atlassian.net/wiki/spaces/~110472138/pages/5677547579/Risk+Analysis+-+Matter+Door+Lock+Capability+Transition+with+API+Partners#6.-Business-Impact-on-the-API-Partner-Program

Summary of Completed Tests

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Channel deleted.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

matter-lock_coverage.xml

File Coverage
All files 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/unmigrated-matter-lock/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 89%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lazy_load_subdriver.lua 57%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 90%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 21b224b

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Test Results

   73 files  ±0    541 suites  ±0   0s ⏱️ ±0s
3 265 tests ±0  3 265 ✅ ±0  0 💤 ±0  0 ❌ ±0 
5 254 runs  ±0  5 254 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 21b224b. ± Comparison against base commit 71bbd3d.

@hcarter-775

Copy link
Copy Markdown
Contributor

I haven't tested this myself yet, though I do plan to see if this solves the issues with addUser I was seeing. Still, this changeset is small and clear enough in my opinion where this does nothing but strengthen the logic.

@hcarter-775

Copy link
Copy Markdown
Contributor

addUser now works using the VDA as well 👍 .

@HunsupJung
HunsupJung merged commit 19bb6f9 into main Sep 11, 2026
22 checks passed
@HunsupJung
HunsupJung deleted the fix/add-user-and-add-credential branch September 11, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants