Fix addUser() -> addCredential() issue - #3220
Merged
Merged
Conversation
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
|
Channel deleted. |
|
matter-lock_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 21b224b |
hcarter-775
approved these changes
Sep 9, 2026
Contributor
|
I haven't tested this myself yet, though I do plan to see if this solves the issues with addUser I was seeing. Still, this changeset is small and clear enough in my opinion where this does nothing but strengthen the logic. |
ctowns
approved these changes
Sep 10, 2026
Contributor
|
addUser now works using the VDA as well 👍 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
https://smartthings.atlassian.net/wiki/spaces/~110472138/pages/5677547579/Risk+Analysis+-+Matter+Door+Lock+Capability+Transition+with+API+Partners#6.-Business-Impact-on-the-API-Partner-Program
Summary of Completed Tests