Misc events - #8801
Open
AnOwlBe wants to merge 15 commits into
Open
Conversation
AnOwlBe
requested review from
Efnilite,
Pesekjak and
sovdeeth
and removed request for
a team
July 28, 2026 05:37
skriptlang-automation
Bot
added
needs reviews
This comment has been minimized.
This comment has been minimized.
sovdeeth
reviewed
Jul 28, 2026
sovdeeth
left a comment
sovdeeth
left a comment
Member
There was a problem hiding this comment.
Pretty much every text block has spaces instead of tabs for indentation.
Also, please note any changes/bug fixes you decided to make in the PR description. If you don't, it's unclear whether they were intended to be in this PR and easier for reviewers to miss checking.
sovdeeth
added
enhancement
Contributor
Author
|
Fixed the issues with spaces instead of tabs and for the changes this PR specifically has not many (the other ones do have a chunk) the only notable change is the broadcast pattern |
sovdeeth
requested changes
Jul 28, 2026
…s/EvtPeriodical.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
…s/EvtPeriodical.java Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
sovdeeth
approved these changes
Jul 28, 2026
APickledWalrus
requested changes
Jul 30, 2026
| .supplier(() -> new SimpleEvent("server list ping")) | ||
| .build()); | ||
|
|
||
| syntaxRegistry.register(BukkitSyntaxInfos.Event.KEY, BukkitSyntaxInfos.Event.builder(SimpleEvent.class, "Anvil Prepare") |
Member
There was a problem hiding this comment.
Seems like this should be somewhere within BlockModule
Contributor
Author
There was a problem hiding this comment.
maybe in InventoryEvents since it extends paper.event.inventory.PrepareResultEvent but I don't think block events would fit
| .supplier(() -> new SimpleEvent("broadcast message")) | ||
| .build()); | ||
|
|
||
| syntaxRegistry.register(BukkitSyntaxInfos.Event.KEY, BukkitSyntaxInfos.Event.builder(SimpleEvent.class, "Server List Ping") |
Member
There was a problem hiding this comment.
Some sort of server module might be good given the existence of other related syntaxes
Contributor
Author
There was a problem hiding this comment.
Maybe in the future but for 1 single event its a bit overkill
skriptlang-automation
Bot
removed
the
needs reviews
…s/EvtAtTime.java Co-authored-by: Patrick Miller <apickledwalrus@icloud.com>
Absolutionism
requested changes
Jul 30, 2026
Absolutionism
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This is part idk at this point of probably 6-8 more prs needed to migrate all of simpleevents & njol/skript/events into the skriptlang folder in their related module while (hopefully) preventing any breaking changes.
Solution
Migrates misc events
Progress:
message being broadcast[ed])Enchantment Events:
Testing Completed
Manual testing completeld
quickTest ran successfully
JUnitQuick failed due to a random expr failing for some reason? not sure why exactly since the expr is not an event expr nore related to the events I changed at all but will look into it if tests fail here too
Supporting Information
Completes: none
Related: none
AI assistance: none