Events Migration (Player Events 2) - #8761
Open
AnOwlBe wants to merge 17 commits into
Open
Conversation
AnOwlBe
requested review from
TheMug06,
erenkarakal and
sovdeeth
and removed request for
a team
July 8, 2026 02:00
skriptlang-automation
Bot
added
the
needs reviews
Absolutionism
requested changes
Jul 21, 2026
…nts/events/EvtPlayerFirstJoin.java Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
…nts/events/EvtPlayerCommandSend.java Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
sovdeeth
requested changes
Jul 28, 2026
skriptlang-automation
Bot
added
needs reviews
Co-authored-by: sovdee <10354869+sovdeeth@users.noreply.github.com>
sovdeeth
requested changes
Jul 29, 2026
skriptlang-automation
Bot
removed
the
needs reviews
sovdeeth
approved these changes
Jul 29, 2026
sovdeeth
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This is part 4 of probably 6-8 more prs needed to migrate all of simpleevents & njol/skript/events into the skriptlang folder in their related module while (hopefully) preventing any breaking changes.
Solution
progress:
registrytoEventValueRegistryn also did a bit of spacing incheckTesting Completed
quicktest ran successfully junit did not (due to version mismatch so will have to rely on githubs junit tests) also manual testing completed for each event all appear to work fine
for those who want to test:
playerevents2.txt
Supporting Information
Note that the stuff in BukkitModule will exist until #8741 replaces it when 2.16 is officially out allowing it to be merged into dev/feature
Completes: none
Related: #8754, #8748 & #8716
AI assistance: none