Skip to content

[3.0] Theme split (wave 5, part 2) — give the default theme a dark mode #9497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdarwood007 merged 2 commits into from
Aug 23, 2026
Merged

[3.0] Theme split (wave 5, part 2) — give the default theme a dark mode #9497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
258c5d2
Gives the last hard-coded colours in index.css a token
albertlast Aug 11, 2026
5f8261b
Gives the default theme a dark mode
albertlast Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Sources/Theme.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,8 @@ public function initialize(): void

$this->loadCss();

$this->loadMode();

$this->loadVariant();

Utils::$context['tabindex'] = 1;
Expand Down Expand Up @@ -2208,7 +2210,7 @@ protected function loadMode(): void
'replace',
'{db_prefix}themes',
['id_theme' => 'int', 'id_member' => 'int', 'variable' => 'string-255', 'value' => 'string-65534'],
[self::$current->settings['theme_id'], User::$me->id, 'theme_colormode', $_SESSION['theme_colormode']],
[[self::$current->settings['theme_id'], User::$me->id, 'theme_colormode', $_SESSION['theme_colormode']]],
['id_theme', 'id_member', 'variable'],
);
}
Expand All @@ -2224,7 +2226,15 @@ protected function loadMode(): void
Utils::$context['theme_colormode'] = !empty($this->settings['default_colormode']) && \in_array($this->settings['default_colormode'], $this->settings['theme_colormodes']) ? $this->settings['default_colormode'] : $this->settings['theme_colormodes'][0];
}

self::loadCSSFile('dark.css', ['order_pos' => 2, 'attributes' => (Utils::$context['theme_colormode'] == 'system' ? ['media' => '(prefers-color-scheme: dark)'] : [])], 'smf_dark');
// In 'system' mode the media attribute is the whole mechanism: it is
// what asks the browser rather than the member. But attributes are
// only printed for files served on their own - a file folded into
// the minified bundle loses them - so this is the one mode that has
// to stay out of it. The other two carry no attribute and bundle as
// usual, which also lets them share one cached file.
$system_mode = Utils::$context['theme_colormode'] == 'system';

self::loadCSSFile('dark.css', ['minimize' => !$system_mode, 'order_pos' => 2, 'attributes' => ($system_mode ? ['media' => '(prefers-color-scheme: dark)'] : [])], 'smf_dark');
}
}

Expand Down
Loading