Skip to content

[3.0] Print the registration errors that carry their own words #9485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
albertlast wants to merge 1 commit into
base: release-3.0
Choose a base branch
from
Open

[3.0] Print the registration errors that carry their own words #9485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Sources/Actions/Register2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,12 @@ public static function registerMember(array &$reg_options, bool $return_errors =
1 = The text/index.
2 = Whether to log.
3 = sprintf data if necessary. */
$message = Lang::getTxt($error[1], (array) ($error[3] ?? []), file: 'Errors');
// A 'done' error carries its own words - the password strength
// feedback and "that name is already in use" are both built as
// sentences rather than keys. Looking them up in Errors finds
// nothing and getTxt() hands back an empty string, which is what
// the registration form was printing: a bullet with no text in it.
$message = ($error[0] ?? 'lang') === 'done' ? $error[1] : Lang::getTxt($error[1], (array) ($error[3] ?? []), file: 'Errors');

// What to do, what to do, what to do.
if ($return_errors) {
Expand Down