Skip to content

[3.0] Name the icons in the message icon picker #9479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
live627 merged 1 commit into from
Aug 10, 2026
Merged

[3.0] Name the icons in the message icon picker #9479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Themes/default/scripts/topic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,8 +288,12 @@ IconList.prototype.onIconsReceived = function (oXMLDoc)

const img = document.createElement('img');
img.src = icon.getAttribute('url');
img.alt = icon.getAttribute('name');
img.title = icon.firstChild ? icon.firstChild.nodeValue : '';
/*
* The icon's name is its text, not an attribute - there has never been
* a name attribute on these. Asking for one gave every icon in the
* picker alt="null".
*/
img.alt = img.title = icon.firstChild ? icon.firstChild.nodeValue : '';
img.style.verticalAlign = 'middle';

span.appendChild(img);
Expand Down