Refactor CMake with JRL CMake Modules v2 (v2) - #40
Open
ahoarau wants to merge 72 commits into
Open
Conversation
ahoarau
marked this pull request as draft
January 5, 2026 14:05
ManifoldFR
marked this pull request as ready for review
January 9, 2026 20:55
ManifoldFR
enabled auto-merge
January 9, 2026 20:55
ManifoldFR
reviewed
Jan 9, 2026
ManifoldFR
left a comment
ManifoldFR
left a comment
Member
There was a problem hiding this comment.
Seems good to me overall 😄
ahoarau
marked this pull request as draft
January 10, 2026 07:25
auto-merge was automatically disabled
January 10, 2026 07:25
Pull request was converted to draft
ManifoldFR
marked this pull request as ready for review
January 10, 2026 16:01
ahoarau
marked this pull request as draft
January 12, 2026 06:29
ahoarau
force-pushed
the
jrl-next-v2
branch
2 times, most recently
from
January 16, 2026 09:56
5cedb44 to
099bd00
Compare
ManifoldFR
marked this pull request as ready for review
January 17, 2026 10:00
ahoarau
force-pushed
the
jrl-next-v2
branch
2 times, most recently
from
January 17, 2026 11:28
05572ce to
fcf926d
Compare
ManifoldFR
approved these changes
Jan 17, 2026
Member
|
@nim65s we will need a followup PR for Nix in the future 😃 |
ahoarau
force-pushed
the
jrl-next-v2
branch
2 times, most recently
from
February 6, 2026 08:55
31fceae to
e300dd5
Compare
ahoarau
force-pushed
the
jrl-next-v2
branch
2 times, most recently
from
March 18, 2026 15:47
5b8813f to
d8ac8b7
Compare
ahoarau
force-pushed
the
jrl-next-v2
branch
2 times, most recently
from
May 11, 2026 12:03
7b4631c to
a747b22
Compare
jorisv
requested changes
Jun 2, 2026
ahoarau
force-pushed
the
jrl-next-v2
branch
2 times, most recently
from
July 28, 2026 15:26
15991d9 to
740f19f
Compare
eigen does not initialize matrices at construction by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a full rewrite of the CMake files with the JRL CMake Modules v2.
pytestNOTE: This the commit are cherry-picked and squashed from the previously accidentitaly merged #28