Repository navigation
Ensure authentication is passed to swift library correctly - #372
Merged
Merged
Conversation
| /** | ||
| * Optional checkout options (authentication, entryPoint) | ||
| */ | ||
| RCT_EXPORT_VIEW_PROPERTY(checkoutOptions, NSDictionary*) |
Contributor
There was a problem hiding this comment.
We've removed checkoutOptions from the JS interface so we can remove this I think
Do we need a way to pass entryPoint in still?
| guard !pendingSetup else { return } | ||
| pendingSetup = true | ||
|
|
||
| DispatchQueue.main.async { [weak self] in |
Contributor
There was a problem hiding this comment.
Did AI ever answer why it has to be async?
Contributor
Author
There was a problem hiding this comment.
The idea was to to batch up, by deferring the actual setup to the next run-loop tick..
For that case where both checkoutUrl and auth change, and we only want to create the viewcontroller once. Will double check it's necessary
Contributor
Author
There was a problem hiding this comment.
yeah, seems necessary, seeing tests fail with multiple setups otherwise
…header extract token client, add error handling code review improvements
kiftio
changed the title
kieran-osgood-shopify
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
authprop, rather thanoptionsPart of the issue is that previously the component was being created multiple times, e.g.
Combined with preloading and a missing invalidate this can cause issues.
We also saw an issue where color scheme changes weren't being reflected in the UI, so have looked at fixing that by moving ConfigProvider up and adding an effect to watch
appConfig.colorSchemePR Checklist
Important
Releasing a new version of the kit?
package.jsonfile.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.