Skip to content

Handle standard errors in meta protocol parser#85

Open
mrattle wants to merge 1 commit into
mainfrom
mrattle/handle-meta-errors
Open

Handle standard errors in meta protocol parser#85
mrattle wants to merge 1 commit into
mainfrom
mrattle/handle-meta-errors

Conversation

@mrattle

@mrattle mrattle commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • parse standard memcached error responses in meta protocol handlers
  • map ERROR, CLIENT_ERROR, and SERVER_ERROR to existing ErrorKind variants
  • drain the internal quiet-mode no-op response after non-no-op quiet meta responses so pooled/reused clients stay stream-aligned
  • report unexpected quiet drain responses by response kind/status
  • add parser coverage for meta get/set/delete/arithmetic error responses
  • add fake-server quiet-mode regression coverage for meta_get, meta_set, meta_delete, meta_increment, and meta_decrement, including follow-up requests on the same client
  • add fake-server coverage for unexpected quiet drain status/data responses

Testing

  • cargo fmt
  • cargo test 'test_quiet_meta' --test meta_proto_integration_tests
  • cargo test

@mrattle mrattle requested a review from a team as a code owner July 7, 2026 20:37
@mrattle mrattle force-pushed the mrattle/handle-meta-errors branch 3 times, most recently from f5c3f78 to 0f74076 Compare July 7, 2026 22:00
Assisted-By: devx/2de6bd4a-aeaa-4463-b734-383caca64107
@mrattle mrattle force-pushed the mrattle/handle-meta-errors branch from 0f74076 to 39fc285 Compare July 7, 2026 22:56
@mrattle mrattle self-assigned this Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant