Skip to content

Prowler scan: creds + non‑failing runs; ANSI log UX polish - #48

Merged
LuD1161 merged 6 commits into
mainfrom
feat/prowler-scan-updates
Nov 3, 2025
Merged

LuD1161 merged 6 commits into
mainfrom
feat/prowler-scan-updates

Conversation

@LuD1161

@LuD1161 LuD1161 commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

Prowler scan improvements and log UX polish.

What’s in

  • Worker (Prowler)
    • Pass AWS creds via env and mounted ~/.aws; set region defaults.
    • Default non‑failing runs: add --ignore-exit-code-3 and handle exit 3.
    • Correct v4 severity syntax: --severity high critical.
    • Parse ASFF, return findings/summary, clean temp dirs.
  • SDK
    • Docker runner: add platform + volumes (needed for ~/.aws + output mount).
  • Frontend
    • Sidebar logs: colorize ANSI in previews.
    • Message modal: ANSI rendering, Word Wrap + Colorize toggles (persisted), stable scrolling.

Validation

  • A run with findings now completes (no exit 3 failure).
  • ANSI is colored in both sidebar preview and modal.
  • Typecheck passes across packages.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +709 to +710
componentRegistry.register(definition);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Ensure prowler scan module is loaded into component registry

The new component calls componentRegistry.register(definition), but worker/src/components/index.ts still only imports the existing security modules (subfinder, amass, naabu, dnsx, httpx, notify). Because this file is never imported there, the registration side effect never runs and componentRegistry.get('security.prowler.scan') will keep returning undefined, making the component unusable at runtime. Add an import in the index so this module is executed during startup.

Useful? React with 👍 / 👎.

Comment thread worker/src/components/security/__tests__/cspm-stubs.test.ts Outdated
@LuD1161

LuD1161 commented Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

This is running seamlessly now -
image

@LuD1161
LuD1161 force-pushed the feat/prowler-scan-updates branch from bb1980d to c575b87 Compare November 3, 2025 00:14
…ockerRunnerConfig with platform + volumes\n- Pass platform and -v mounts to 'docker run' arguments
…on-failing defaults\n\n- Inject AWS creds via env + mounted ~/.aws\n- Default to --ignore-exit-code-3 (and handle exit code 3)\n- Correct v4 --severity syntax (space-separated)\n- Parse ASFF output, summarize, and cleanup temp dirs
…named import\n\n- Detect ANSI sequences and render colorized HTML in MessageModal\n- Add ansi_up dependency
@LuD1161
LuD1161 force-pushed the feat/prowler-scan-updates branch from c575b87 to 76c0261 Compare November 3, 2025 00:20
…Make dialog body a flex column with a dedicated overflow-y area\n- Set a minimum content height for stable scrollbars
…th persisted prefs\n\n- Toggle wrap and ANSI colorization per user preference\n- Persist choices in localStorage and default colorize to presence of ANSI\n- Keep scroll behavior stable
…ansi_up\n\n- Detect ANSI escape codes in preview text and colorize\n- Keep plain <pre> for non-ANSI entries
@LuD1161 LuD1161 changed the title feat: overhaul prowler scan component Prowler scan: creds + non‑failing runs; ANSI log UX polish Nov 3, 2025
@LuD1161
LuD1161 merged commit 5c1758e into main Nov 3, 2025
1 check passed
@LuD1161
LuD1161 deleted the feat/prowler-scan-updates branch November 3, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant