Fix: Improve poll rate for source devices - #641
Merged
Conversation
pastaq
force-pushed
the
pastaq/lego_polling
branch
from
August 18, 2026 19:33
9867be2 to
4888fec
Compare
- Calculates the total poll time for each source device and sleeps for only the remainder of the devices poll rate. With the previous implementation a source device could effectively halve its poll rate by waiting the full duration. If a device took 8ms to fill its event buffer and produce events, and its poll rate needed an 8ms sleep, that would effectively make the delay 16ms.
pastaq
force-pushed
the
pastaq/lego_polling
branch
from
August 21, 2026 04:56
4888fec to
f17425e
Compare
pastaq
changed the title
pastaq
marked this pull request as ready for review
August 21, 2026 04:57
Contributor
|
🎉 This PR is included in version 0.78.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a fix for source device run loop that prevents halving the poll rate. Previously it would unconditionally sleep for the duration of the poll interval. Now it calculates the time spent draining the source device and creating events and sleeps for the remainder.