Skip to content

[py] generate the internal BiDi protocol layer from the shared binding-neutral schema #17761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
titusfortner wants to merge 12 commits into
base: trunk
Choose a base branch
from
+7,143 −3
Draft

[py] generate the internal BiDi protocol layer from the shared binding-neutral schema #17761

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
29d7496
[py] add internal generated BiDi protocol layer with check-in generat…
titusfortner Jul 6, 2026
d90f1a7
[py] align BiDi inbound validation with guide: integer accepts float,…
titusfortner Jul 7, 2026
c96b34d
[py] BiDi integer validation rejects non-integer floats
titusfortner Jul 7, 2026
d682be2
[py] drop dead unknown-primitive handling from BiDi generator
titusfortner Jul 7, 2026
9aff3ac
[py] wire verify-bidi-protocol into CI unit-tests job
titusfortner Jul 7, 2026
fb42320
[py] add browser round-trip tests for generated _bidi layer
titusfortner Jul 7, 2026
f83919a
[py] add unit tests for _bidi serialization and transport runtime
titusfortner Jul 8, 2026
2a3b2ce
[py] store one shared BiDi Transport on the driver
titusfortner Jul 8, 2026
929d403
[py] add unit tests for the generated BiDi command surface
titusfortner Jul 8, 2026
1836a44
[py] fix _bidi runtime docstrings and add _command return annotation
titusfortner Jul 10, 2026
95c1395
[py] remove verify-bidi-protocol test and CI step pending build-time …
titusfortner Jul 11, 2026
17a27d3
[py] copy the generated _bidi package in local_dev rake task
titusfortner Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
name: Unit Tests (${{ matrix.python-version }}, ${{ matrix.os }})
os: ${{ matrix.os }}
python-version: ${{ matrix.python-version }}
run: bazel test --local_test_jobs 1 //py:unit
run: bazel test --local_test_jobs 1 //py:unit //py:verify-bidi-protocol

remote-tests:
name: Remote Tests
Expand Down
38 changes: 37 additions & 1 deletion py/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ load("@bazel_skylib//rules:select_file.bzl", "select_file")
load("@py_dev_requirements//:requirements.bzl", "requirement")
load("@rules_pkg//pkg:mappings.bzl", "pkg_files", "strip_prefix")
load("@rules_pkg//pkg:pkg.bzl", "pkg_tar")
load("@rules_python//python:defs.bzl", "py_binary", "py_library")
load("@rules_python//python:defs.bzl", "py_binary", "py_library", "py_test")
load("@rules_python//python:packaging.bzl", "py_package", "py_wheel")
load("@rules_python//python:pip.bzl", "compile_pip_requirements")
load("@rules_python//python/entry_points:py_console_script_binary.bzl", "py_console_script_binary")
Expand Down Expand Up @@ -532,6 +532,7 @@ py_library(
visibility = ["//visibility:public"],
deps = [
":bidi",
":bidi_protocol",
":chrome",
":chromium",
":common",
Expand Down Expand Up @@ -561,6 +562,7 @@ py_package(
"py.selenium",
"py.selenium.common",
"py.selenium.webdriver",
"py.selenium.webdriver._bidi",
"py.selenium.webdriver.chrome",
"py.selenium.webdriver.chromium",
"py.selenium.webdriver.common",
Expand Down Expand Up @@ -748,6 +750,39 @@ generate_bidi(
spec_version = "1.0",
)

# Schema-driven BiDi protocol layer (ADR 17701): generated from the shared BiDi
# schema into the checked-in, internal `selenium/webdriver/_bidi/` package.
# Check-in mode — the committed files are the build input; verify-bidi-protocol
# guards them against staleness / hand-edits.
py_binary(
name = "generate-bidi-protocol",
srcs = ["generate_bidi_protocol.py"],
args = ["$(location //javascript/selenium-webdriver:create-bidi-src_schema)"],
data = ["//javascript/selenium-webdriver:create-bidi-src_schema"],
main = "generate_bidi_protocol.py",
visibility = ["//visibility:public"],
)

py_library(
name = "bidi_protocol",
srcs = glob(["selenium/webdriver/_bidi/**/*.py"]),
imports = ["."],
visibility = ["//visibility:public"],
deps = [":exceptions"],
)

py_test(
name = "verify-bidi-protocol",
size = "small",
srcs = [
"generate_bidi_protocol.py",
"verify_bidi_protocol.py",
],
args = ["$(location //javascript/selenium-webdriver:create-bidi-src_schema)"],
data = ["//javascript/selenium-webdriver:create-bidi-src_schema"] + glob(["selenium/webdriver/_bidi/*.py"]),
main = "verify_bidi_protocol.py",
)

py_test_suite(
name = "unit",
size = "small",
Expand Down Expand Up @@ -1036,6 +1071,7 @@ FEATURE_SUITE_DEFS = {
target_compatible_with = BROWSERS[browser]["target_compatible_with"],
test_suffix = "%s-bidi" % browser,
deps = [
":bidi_protocol", # bidi_protocol_tests.py imports the generated _bidi layer directly
":common_alert", # bidi_browsing_context_tests.py calls EC.alert_is_present()
":init-tree",
":webserver",
Expand Down
Loading
Loading