template editor: update navigation bar locator#2242
Merged
pnovotny merged 2 commits intoJul 15, 2026
Conversation
pnovotny
added
No-CherryPick
Contributor
Author
|
pnovotny
marked this pull request as ready for review
December 15, 2025 12:27
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
We failed to fetch pull request #2242.
You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.
Satellite-QE
added
the
PRT-Passed
LadislavVasina1
approved these changes
Jan 2, 2026
Contributor
Author
|
Satellite-QE
added
PRT-Failed
pnovotny
force-pushed
the
template-editor-navbar-upd
branch
from
January 14, 2026 11:01
a4e89e3 to
f9ee551
Compare
Contributor
Author
|
Satellite-QE
added
PRT-Passed
Contributor
|
@pnovotny Any update on this? Can we merge? |
Contributor
Author
|
@LadislavVasina1 not ready for merging yet. The dev PR theforeman/foreman#10728 is still in progress. When it's reviewed and merged, I'll re-verify this PR and then it's good to go. |
Contributor
Author
|
pnovotny
removed
the
PRT-Passed
Contributor
|
PRT Result |
Satellite-QE
added
the
PRT-Failed
Locator for the template nagigation bar (Editor/Changes/Preview) has slightly changed. Related to change theforeman/foreman#10728
pnovotny
force-pushed
the
template-editor-navbar-upd
branch
from
July 8, 2026 13:46
f9ee551 to
6a56886
Compare
Contributor
Author
|
Satellite-QE
removed
the
PRT-Failed
Contributor
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
Contributor
Author
|
The actual fixing PR theforeman/foreman#11091 does not require any changes in QE automation, as verified in the latest PRT run. Closing this PR as no longer relevant. |
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
# For PRT onlycomment onrendering_optionsis unclear; consider expanding it to briefly explain what PRT refers to and why this locator differs from other contexts.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `# For PRT only` comment on `rendering_options` is unclear; consider expanding it to briefly explain what PRT refers to and why this locator differs from other contexts.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
Reopening, since this automation fix is acually needed for theforeman/foreman#11099 |
Satellite-QE
removed
the
PRT-Passed
Contributor
Author
|
Contributor
|
PRT Result |
Satellite-QE
added
the
PRT-Passed
Contributor
Author
|
PRT passed. Now waiting only for theforeman/foreman#11099 to be merged... |
Contributor
Author
|
theforeman/foreman#11099 has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locator for the template nagigation bar (Editor/Changes/Preview) has slightly changed.
This verifies PR
theforeman/foreman#10728UPDATE: theforeman/foreman#10728 has been deprecated and replaced by theforeman/foreman#11091UPDATE2: this automation fix is actually needed for theforeman/foreman#11099