[AI Task] Use RunContinuationsAsynchronously for RemoteResource async TCS - #7785
Open
JoonghyunCho wants to merge 1 commit into
Open
[AI Task] Use RunContinuationsAsynchronously for RemoteResource async TCS#7785JoonghyunCho wants to merge 1 commit into
JoonghyunCho wants to merge 1 commit into
Conversation
… TCS (Fixes #7699) Construct the TaskCompletionSource in GetAsync/PutAsync/PostAsync/DeleteAsync with TaskCreationOptions.RunContinuationsAsynchronously so awaiting continuations resume on the ThreadPool instead of running inline on the native iotcon callback thread, removing a deadlock/re-entrancy hazard. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Member
Author
|
|
Member
Author
|
🤖 [AI Review] Reviewed — no findings. Scope checked:
No 🔴 critical issues, no 🟡 suggestions to flag. Automated review — final merge decision rests with human reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RemoteResource.GetAsync/PutAsync/PostAsync/DeleteAsynccreated theirTaskCompletionSource<RemoteResponse>with the default constructor, so the awaiting continuation resumed synchronously on the native iotcon callback thread that callsTrySetResult/TrySetException. This is a classic deadlock / re-entrancy hazard: user code after theawaitcould re-enter native iotcon or block while running inline on the native callback thread. All four TCS constructions now passTaskCreationOptions.RunContinuationsAsynchronously, matching the same fix already applied for WiFi (#7620), NFC (#7676), Bluetooth (#7666), and Remoting (#7639).Changes
src/Tizen.Network.IoTConnectivity/Tizen.Network.IoTConnectivity/RemoteResource.cs: addedTaskCreationOptions.RunContinuationsAsynchronouslyto the 4 method-localTaskCompletionSource<RemoteResponse>constructions inGetAsync,PutAsync,PostAsync, andDeleteAsync.Mode
Refactoring
Verification
Fixes #7699