fix: Telegram interruption can hang forever while closing an uncooperative stream - #1105
Open
sam-saffron-jarvis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Stream.Closeasynchronously and bound cleanup across the stream consumer, direct stream close, and shared runner.Stream.Closeon user interruption and aRunner.Runthat ignores watchdog cancellation.Why this is high-value
Telegram holds the per-chat session mutex for the full response. Previously, interruption and error paths could call
Stream.Closeor wait for runner shutdown without a deadline, leavingreplyDoneopen and the session mutex locked forever. A handful of stalled responses could retain every Telegram handler slot and stop the bot globally. Cleanup is now bounded, the old runtime is quarantined, and a replacement session can process the next message.Validation
gofmt -w internal/serve/telegram.go internal/serve/telegram_test.gogo test ./internal/serve -run 'TestStreamReply_UncooperativeCleanupIsBounded|TestStreamReply_PersistsInterruptedPartialAssistantReply|TestStreamReply_WatchdogTimeoutIsNotTreatedAsUserInterrupt' -count=1go test -race ./internal/serve -run TestStreamReply_UncooperativeCleanupIsBounded -count=1go test ./internal/serve -count=1go build ./...XDG_CONFIG_HOME=$(mktemp -d) go test ./...git diff --check