fix(serve): preserve deprecated enable-widgets flag - #1088
Merged
SamSaffron merged 1 commit intoAug 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serve --enable-widgetsas a compatibility no-op--disable-widgetswhen they need to opt outThis gives existing service definitions and deployment scripts time to migrate after widgets became enabled by default.
Tests
go test ./cmd -run 'TestServeWidgetsAreOptOut|TestDeprecatedEnableWidgetsWarning'go build ./...serve web --enable-widgets: server starts with widgets enabled and emits the expected warninggo test ./...was also run. It has unrelated existing/environment-sensitive failures in two skill-discovery tests and the current frontend bundle-size budget (app.jsis 427,861 bytes against a 426,000-byte raw budget).