fix(select): correct markup in option group header - #8166
Open
tomdavies73 wants to merge 1 commit into
Open
Conversation
instead of rendering the option group header label as a h4 we now render a span instead. This adheres with proper HTML semantics and resolves an axe issue. Some additional styling has also been added to make sure there is no visual regression fix #8157
ibutakova
reviewed
Sep 7, 2026
ibutakova
approved these changes
Sep 7, 2026
mihai-albu-sage
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #8157
Proposed behaviour
Iinstead of rendering the option group header label as a h4 we now render a span instead. This adheres with proper HTML semantics and resolves an axe issue. Some additional styling has also been added to make sure there is no visual regression.
Current behaviour
The option group header label renders as a h4 . This does not adhere with proper HTML semantics and results in an axe issue.
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
Open a story which includes an option group header on this PR and on master. Open the dropdown and run axe dev tools, on master this will result in a failure due to incorrect children, on this PR it will not.