feat(textarea): remove legacy FormField, Label and Input usage - #8116
Merged
Conversation
tamas-sage
marked this pull request as draft
August 7, 2026 09:32
tamas-sage
force-pushed
the
feat/fe-7735-textarea-remove-legacy-label
branch
from
August 10, 2026 08:51
51b24aa to
c103077
Compare
ibutakova
reviewed
Aug 12, 2026
tamas-sage
requested review from
DipperTheDan and
ibutakova
and
a lite review from Copilot
August 13, 2026 08:38
There was a problem hiding this comment.
Pull request overview
This PR completes the migration of Textarea away from legacy FormField, Label, and Input wrappers while preserving existing styling/layout expectations, and updates related stories/tests/docs to reflect the new implementation and corrected textarea event typings.
Changes:
- Refactors
Textareato render a native<textarea>and custom label container while still using legacyInputPresentationfor presentation/states. - Updates Jest + Playwright tests and Storybook stories to match new markup/hooks, including label/hint layout and icon padding.
- Aligns
onChangetypings and documentation toHTMLTextAreaElementacross the component, stories, and skills docs.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/hooks/use-multi-input/use-multi-input.tsx | Broadens change handler typing to support both inputs and textareas. |
| src/components/tile/tile-test.stories.tsx | Fixes textarea onChange typing in a tile story. |
| src/components/textarea/textarea.test.tsx | Updates/extends unit tests for new textarea structure, selectors, and legacy-compat behaviours. |
| src/components/textarea/textarea.style.ts | Reworks styles to target a native textarea and new label container structure. |
| src/components/textarea/textarea.stories.tsx | Updates stories to use textarea-appropriate change event types. |
| src/components/textarea/textarea.pw.tsx | Updates Playwright selectors/assertions for new label container and adaptive label behaviour. |
| src/components/textarea/textarea.component.tsx | Core refactor removing legacy FormField/Label/Input usage and introducing new label container + native textarea. |
| src/components/textarea/textarea-test.stories.tsx | Updates textarea test-story change handler typing. |
| src/components/textarea/components.test-pw.tsx | Updates Playwright component fixtures to use textarea change event types. |
| src/components/form/form.stories.tsx | Updates textarea usage in form story to correct event typing. |
| src/components/form/form-test.stories.tsx | Updates textarea usage in form test story to correct event typing. |
| src/internal/legacy-input/input.test.tsx | Adds/extends tests around legacy input border-radius array + blur behaviour. |
| src/internal/legacy-input/input-presentation.test.tsx | Adds test coverage for focus styling driven by input context. |
| skills/carbon-react/components/textarea.md | Updates generated docs to reflect textarea event typings and updated deprecated-prop descriptions. |
| skills/carbon-react/components/form.md | Updates generated docs snippet to use textarea change event typings. |
| package-lock.json | Lockfile updates from dependency/version resolution changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tamas-sage
force-pushed
the
feat/fe-7735-textarea-remove-legacy-label
branch
from
August 14, 2026 07:59
f475b39 to
2ae37e0
Compare
ibutakova
reviewed
Aug 25, 2026
DipperTheDan
previously approved these changes
Aug 27, 2026
ibutakova
previously approved these changes
Aug 27, 2026
divyajindel
marked this pull request as ready for review
August 27, 2026 23:03
tamas-sage
dismissed stale reviews from ibutakova and DipperTheDan
via
September 3, 2026 11:08
a624565
tamas-sage
force-pushed
the
feat/fe-7735-textarea-remove-legacy-label
branch
from
September 7, 2026 14:58
951c296 to
d0d9805
Compare
ibutakova
approved these changes
Sep 9, 2026
DipperTheDan
approved these changes
Sep 10, 2026
divyajindel
approved these changes
Sep 10, 2026
tamas-sage
force-pushed
the
feat/fe-7735-textarea-remove-legacy-label
branch
from
September 10, 2026 09:10
52b54dd to
a1dc8e3
Compare
nineteen88
approved these changes
Sep 10, 2026
nineteen88
left a comment
Contributor
There was a problem hiding this comment.
Approving skills updates
Collaborator
|
🎉 This PR is included in version 161.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Textarea should remove the remaining legacy wrapper dependency and keep the same layout and styling as before.
Current behaviour
Textareano longer uses legacyFormField,Label, orInput, but it still relies on legacyInputPresentationand has some layout regressions.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions
Test in Storybook:
Open the Textarea stories and verify the component renders correctly across all variants (default, with label, inline label, with character count, with hint text, with validation, error/warning/info).
Confirm focus ring appears correctly on click and keyboard Tab navigation.
Confirm validation messages, character count, and hint text display as expected.
Confirm labelInline layout is correct.
Test inside a Form story to verify the component integrates correctly and validation behaviour is unchanged.
Confirm all themes (mint, sage, carbon, none) render without visual regressions.