-
Notifications
You must be signed in to change notification settings - Fork 88
feat(date): align with fusion ds #8085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ibutakova
wants to merge
12
commits into
master
Choose a base branch
from
FE-7142-align-date-with-fusion-ds
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bc47784
feat(date): align with fusion ds
ibutakova 382d6f1
feat(date): fix click away behaviour and some tests
ibutakova 5eed28a
feat(date): fix select styles, fix close button styles
ibutakova 050c52f
feat(date): fix test
ibutakova 01c4bfb
feat(date): update calendar dialog and trigger accessibility
ibutakova 14dbb1f
feat(date): fix tests
ibutakova 63d559b
feat(date): limit select option to max 12 items. fix trigger active s…
ibutakova a90a54d
feat(date): add calendar navigation test. add strory for disabled yea…
ibutakova 4ed947d
feat(date): remove year/month disabled styles. cleanup story
ibutakova c35d467
feat(date): allow naviation on disabled dates
ibutakova e97f1b3
feat(date): add yearRangeOffset to public API
ibutakova 83408ea
feat(date): fix anchor ref in documents
ibutakova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
src/components/date/__internal__/calendar/calendar-close-button.component.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| import React from "react"; | ||
|
|
||
| import StyledCalendarCloseButton from "./calendar-close-button.style"; | ||
|
|
||
| interface CalendarCloseButtonProps { | ||
| children: React.ReactNode; | ||
| onClick: ( | ||
| event: | ||
| | React.MouseEvent<HTMLAnchorElement> | ||
| | React.MouseEvent<HTMLButtonElement>, | ||
| ) => void; | ||
| } | ||
|
|
||
| const CalendarCloseButton = ({ | ||
| children, | ||
| onClick, | ||
| }: CalendarCloseButtonProps) => ( | ||
| <StyledCalendarCloseButton | ||
| data-role="date-picker-close" | ||
| type="button" | ||
| variant="default" | ||
| variantType="subtle" | ||
| size="small" | ||
| onClick={onClick} | ||
| > | ||
| {children} | ||
| </StyledCalendarCloseButton> | ||
| ); | ||
|
|
||
| export default CalendarCloseButton; |
14 changes: 14 additions & 0 deletions
14
src/components/date/__internal__/calendar/calendar-close-button.style.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import styled from "styled-components"; | ||
|
|
||
| import Button from "../../../button/__next__"; | ||
|
|
||
| const StyledCalendarCloseButton = styled(Button)` | ||
| align-self: flex-end; | ||
|
|
||
| @media (max-width: 480px) { | ||
| align-self: stretch; | ||
| width: 100%; | ||
| } | ||
| `; | ||
|
|
||
| export default StyledCalendarCloseButton; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why centre the close button? Is that standard practice on small screens? Feels odd to move it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me remove centring