Shared cost factor only applied to parking cost

[aber-sandag]

costFactorS2 and costFactorS3 are applied only to parking cost, should be applied to all auto costs for shared rides

ABM/src/asim/configs/resident/trip_mode_choice.csv

Line 14 in b8ed161

util_Shared ride 2 - Parking cost ,Shared ride 2 - Parking cost ,"@(df.parkingCost * df.costFactorS2 * df.autoParkingCostFactor)/(np.maximum(df.income,1000)**df.income_exponent)",,coef_income,,,,,,,,,,,,,,,,,,,,,

Also looks like cost_share_s2 and cost_share_s3 used for non-resident models has inconsistent value. cost_share_s2 is 2 in crossborder/constants.yaml but 0.57 in common/constants.yaml. As a result, shared 2 parking cost is currently divided by 0.57 in visitor model. (Value is overwritten with 2 for visitor but is inconsistent with tour mode choice, see replies)

ABM/src/asim/configs/common/constants.yaml

Line 247 in b8ed161

cost_share_s2: 0.57

ABM/src/asim/configs/visitor/trip_mode_choice.csv

Line 10 in b8ed161

util_S2_park_cost,Shared ride 2 HOV - Parking cost,@df.coef_cost * df.autoParkingCostFactor * df.parking_cost / cost_share_s2,,coef_one,,,,,,,,,

Shared cost factor appears to be missing completely from airport model

ABM/src/asim/configs/common_airport/trip_mode_choice.csv

Line 27 in b8ed161

util_park2_parkcost,Parking cost at parking location 2,@(df['nights']*parkLocation2CostDay + parkLocation2CostDay)*100,,coef_c_cost,,,,,,,,,,,,,,,,,,,,,,,,,,

[aber-sandag]

Visitor tour mode choice has shared cost factors set to 1, inconsistent with visitor trip mode choice where shared 2 parking cost is divided by 0.57

https://github.com/SANDAG/ABM/blob/ABM3_develop/src/asim/configs/visitor/tour_mode_choice_annotate_choosers_preprocessor.csv#L166

https://github.com/SANDAG/ABM/blob/ABM3_develop/src/asim/configs/visitor/tour_mode_choice.csv#L17

[aber-sandag]

Looks like the value of cost_share_s2 is overwritten in visitor trip_mode_choice.yaml, so visitor trip mode choice is being divided by 2, not by 0.57. Would still be good to update the value in common constants.yaml for consistency, and is still inconsistent with visitor tour mode choice

[aber-sandag]

We should also be splitting up TNC and Taxi costs per-passenger. Should this be done using the average occupancy for these modes?