-
Notifications
You must be signed in to change notification settings - Fork 1
pin(authoriser): the Fireblocks signer's grants are revoked — negative map pin #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hardyjosh
wants to merge
5
commits into
main
Choose a base branch
from
pin/fireblocks-signer-revoked
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bde505e
pin(authoriser): the Fireblocks signer's grants are revoked — negativ…
fd8b88f
Merge remote-tracking branch 'origin/main' into restack-299
thedavidmeister b0cff6a
Merge remote-tracking branch 'origin/main' into pin/fireblocks-signer…
a5f854e
docs(script): stamp the Fireblocks revocation EXECUTED with its bundl…
a1b41fe
fix(script): the governance-loop proof re-grants the ACTIVE signer
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Build the revocation set from
revokedGrants().LibAuthoriserInvariants.expectedGrants(safeAddr)is now the 13-entry post-rotation map, so it contains noRETIRED_SIGNERentries. However,authorBundlestill scans that map at Lines 190-206 to populateretired.pairCounttherefore remains zero, and the script revertsFireblocksSignerAlreadyRevokedbefore it can create a pre-revocation bundle.assertPostRevocationStatehas the same issue at Lines 258-265. Its retired-signer branch is unreachable, so it does not explicitly verify the threerevokedGrants()pairs are absent. UserevokedGrants()for both the revocation transaction list and the post-state absence check. KeepexpectedGrants()for active-grant drift validation.🤖 Prompt for AI Agents