docs: governance timelock runbook - #288
Conversation
|
Warning Review limit reached
Next review available in: 41 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c7d353c to
bd359aa
Compare
cc87bc5 to
2f457cd
Compare
8ee276d to
ff072b0
Compare
195bd48 to
e3d5ff7
Compare
ff072b0 to
a1250e5
Compare
e3d5ff7 to
54124fc
Compare
a1250e5 to
c416c40
Compare
38ca6c8 to
84cabb3
Compare
c416c40 to
6e69e39
Compare
84cabb3 to
260c991
Compare
6e69e39 to
ee70d26
Compare
260c991 to
009d091
Compare
ee70d26 to
af13b89
Compare
009d091 to
b173b41
Compare
af13b89 to
2c016ca
Compare
docs/TIMELOCK.md: role model (Safe = proposer/canceller/executor, 48h min delay, timelock self-administered, deploy key never holds anything), deterministic per-chain addresses + pin constants, the four-step per-chain rollout (deploy broadcast -> pin PR -> CI-authored Safe bundle -> execute -> post-execution flip PR), how future governance actions work (schedule -> 48h -> execute, batching, cancellation), the invariant surface, the dedicated-canceller placeholder, and explicit out-of-scope follow-ups (beacon ownership, HyperEVM). CLAUDE.md: Governance section pointing script authors at LibTimelockInvariants.timelockForChainId and the schedule/execute pattern for any bundle touching onlyOwner/_ADMIN surfaces. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RquYKmoEVSfuVHy8kwn1yT
b173b41 to
f11215e
Compare
2c016ca to
025f7e6
Compare
…tion Match the runbook to the lib: assertTimelockState asserts against the pinned TIMELOCK_RUNTIME_CODEHASH literal of the frozen TIMELOCK_CREATION_CODE generation, so compiler-settings or dependency changes cannot drift the expectation away from the live deployment. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…eploy Two sections still described the retired rollout mechanics: pins framed as address(0)-until-hydrated-by-a-post-deploy-PR (pins are now written with the chain arm, derived from the frozen bytecode before any deploy, zero refused by every consumer, the equality test unconditional and renamed), and the deploy framed as a per-network dispatch (it is one dispatch iterating networks() with skip-with-assert idempotency). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Reviewed 229c61c: ship — the governance timelock runbook and CLAUDE.md governance section, fact-checked claim by claim against code, tests, and live chain state: role model, deploy-key-holds-nothing, no-open-roles, canceller mechanics, owner-freeze surface (verified onlyOwner in OwnerFreezable), operating mechanics, deadline paragraph matching the merged forcing function, and the frozen-pin invariants section. Docs-only diff; all checks green; no unresolved review threads. |

docs/TIMELOCK.md: role model (Safe = proposer/canceller/executor, 48h min
delay, timelock self-administered, deploy key never holds anything),
deterministic per-chain addresses + pin constants, the four-step per-chain
rollout (deploy broadcast -> pin PR -> CI-authored Safe bundle -> execute
-> post-execution flip PR), how future governance actions work
(schedule -> 48h -> execute, batching, cancellation), the invariant
surface, the dedicated-canceller placeholder, and explicit out-of-scope
follow-ups (beacon ownership, HyperEVM).
CLAUDE.md: Governance section pointing script authors at
LibTimelockInvariants.timelockForChainId and the schedule/execute pattern
for any bundle touching onlyOwner/_ADMIN surfaces.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01RquYKmoEVSfuVHy8kwn1yT