Model deploy pins as a rolling candidate + frozen releases (audited 0_1_1 preserved) - #283
Merged
Merged
Conversation
Move st0x.deploy to the tag-release lifecycle with a rolling, unnamed `candidate` snapshot as the source-of-truth for current source: - BuildPointers regenerates src/generated/candidate/ from current source every run (CANDIDATE_TAG constant, _CANDIDATE constant suffix, tag sort places candidate last); numbered snapshots (0_1_1) are frozen-historical and never regenerated. LibProdDeployCurrent -> candidate, so source self-references (incl. the orchestrator) track current source. - Drop the non-audited numbered snapshots 0_1_2..0_1_11 (bad-workflow noise). Keep only the audited, live-on-Base 0_1_1 snapshot, byte-identical. - Repoint tests/scripts off the removed 0_1_3 pins to _CANDIDATE; drop the cross-version (0_1_2 twin) tests. Replace testDeployTag with testCandidateSelfConsistent (stored CREATION_CODE == type(C).creationCode). - package-release.yaml -> rainix-tag-release (tag-triggered); script/cut-release.sh freezes candidate into src/generated/<version>/ at release. - foundry.toml [package].version = 0.1.1 (last published baseline). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 38 seconds Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe release workflow now runs on ChangesCandidate release lifecycle
Candidate deployment expectations
Candidate artifact and redeploy verification
Candidate address adoption across tests
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
script/BuildPointers.sol (1)
65-76: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winStale docstring contradicts the new
deployTag()semantics.The
@param namedoc still sayssrc/generated/<tag>/is the "frozen per-release snapshot for the currentdeployTag()(read from the canonicalfoundry.tomlversion)", butdeployTag()was just changed to apurefunction that always returnsCANDIDATE_TAG— it no longer readsfoundry.toml. This directly contradicts the correct doc a few lines above (L32-38) describingcandidateas the rolling, never-frozen snapshot. Leaving both docs in the same file will mislead future readers about which directory is safe to overwrite.📝 Proposed doc fix
/// `@param` name Must exactly match the contract's Solidity filename (without /// `.sol`), as it determines the generated pointer file path under - /// `src/generated/<tag>/` — the frozen per-release snapshot for the current - /// `deployTag()` (read from the canonical `foundry.toml` version). Historical - /// tags are never regenerated; a release bump writes a new `<tag>/` snapshot - /// beside them. + /// `src/generated/<tag>/` — always `candidate` (`deployTag()` is now pure + /// and never reads `foundry.toml`), the rolling snapshot regenerated from + /// current source on every run. Numbered `<tag>/` snapshots are frozen only + /// by `script/cut-release.sh` and are never written here.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@script/BuildPointers.sol` around lines 65 - 76, Update the `@param` name documentation in buildContractPointers to describe src/generated/<tag>/ as the rolling candidate snapshot selected by deployTag() and safe to overwrite, rather than a frozen release snapshot read from foundry.toml. Keep the historical-tag behavior and the correct candidate semantics documented consistently with the surrounding deployTag documentation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/package-release.yaml:
- Around line 8-30: Replace the blanket secrets: inherit setting in the
rainix-tag-release reusable workflow invocation with explicit mappings for only
the release and publish secrets required by rainix-tag-release. Preserve the
existing permissions and with parameters, and use the repository’s established
secret names rather than exposing all available secrets.
In `@script/cut-release.sh`:
- Around line 25-32: Update the release-directory handling in cut-release.sh to
check whether src/generated/${TAG} already exists before removing or copying
anything. If it exists, stop with an error and preserve the existing snapshot;
only create the directory and copy candidate when the tag path is absent. Remove
the unconditional rm -rf so release snapshots remain append-only.
In `@test/src/concrete/ST0xOrchestrator.t.sol`:
- Around line 64-72: Update the comment above DEPLOYER, VAULT_BEACON,
RECEIPT_BEACON, EXPECTED_VAULT_IMPL, and EXPECTED_RECEIPT_IMPL to describe these
constants as the rolling candidate snapshot, removing the stale reference to
current-release 0.1.3 pins. Leave the constant definitions unchanged.
In `@test/src/lib/LibProdDeployV4.t.sol`:
- Around line 167-169: Replace stale “0.1.3” wording with candidate/current
mover set terminology: update the StoxCorporateActionsFacet comment beside the
_CANDIDATE reference in test/src/lib/LibProdDeployV4.t.sol lines 167-169, and
update the checkAllV4OnChain comments and all related assertion failure messages
in test/src/concrete/deploy/StoxProdV4.t.sol lines 195-333. No code or assertion
behavior changes are needed.
- Around line 548-559: Update the comment above
testFrozenRedeployStoxWrappedTokenVaultBeaconSetDeployer_CANDIDATE to remove the
stale “standalone”/no-predeploy implication. State that no beacon bytecode is
baked into the deployer artifact, while the deployed BeaconProxy checks the
beacon at proxy construction time; leave the test logic unchanged.
---
Outside diff comments:
In `@script/BuildPointers.sol`:
- Around line 65-76: Update the `@param` name documentation in
buildContractPointers to describe src/generated/<tag>/ as the rolling candidate
snapshot selected by deployTag() and safe to overwrite, rather than a frozen
release snapshot read from foundry.toml. Keep the historical-tag behavior and
the correct candidate semantics documented consistently with the surrounding
deployTag documentation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4785a1aa-348e-4aef-84aa-94a995f0490e
⛔ Files ignored due to path filters (98)
src/generated/0_1_2/ST0xOrchestrator.pointers.solis excluded by!**/generated/**src/generated/0_1_2/ST0xOrchestratorBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_2/StoxCorporateActionsFacet.pointers.solis excluded by!**/generated/**src/generated/0_1_2/StoxOffchainAssetReceiptVaultAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/0_1_2/StoxOffchainAssetReceiptVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_2/StoxOffchainAssetReceiptVaultPaymentMintAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/0_1_2/StoxReceipt.pointers.solis excluded by!**/generated/**src/generated/0_1_2/StoxReceiptVault.pointers.solis excluded by!**/generated/**src/generated/0_1_2/StoxUnifiedDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_2/StoxWrappedTokenVault.pointers.solis excluded by!**/generated/**src/generated/0_1_2/StoxWrappedTokenVaultBeacon.pointers.solis excluded by!**/generated/**src/generated/0_1_2/StoxWrappedTokenVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_3/ST0xOrchestrator.pointers.solis excluded by!**/generated/**src/generated/0_1_3/ST0xOrchestratorBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_3/StoxCorporateActionsFacet.pointers.solis excluded by!**/generated/**src/generated/0_1_3/StoxOffchainAssetReceiptVaultAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/0_1_3/StoxOffchainAssetReceiptVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_3/StoxOffchainAssetReceiptVaultPaymentMintAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/0_1_3/StoxReceipt.pointers.solis excluded by!**/generated/**src/generated/0_1_3/StoxReceiptVault.pointers.solis excluded by!**/generated/**src/generated/0_1_3/StoxUnifiedDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_3/StoxWrappedTokenVault.pointers.solis excluded by!**/generated/**src/generated/0_1_3/StoxWrappedTokenVaultBeacon.pointers.solis excluded by!**/generated/**src/generated/0_1_3/StoxWrappedTokenVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_4/ST0xOrchestrator.pointers.solis excluded by!**/generated/**src/generated/0_1_4/ST0xOrchestratorBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_4/StoxCorporateActionsFacet.pointers.solis excluded by!**/generated/**src/generated/0_1_4/StoxOffchainAssetReceiptVaultAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/0_1_4/StoxOffchainAssetReceiptVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_4/StoxOffchainAssetReceiptVaultPaymentMintAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/0_1_4/StoxReceipt.pointers.solis excluded by!**/generated/**src/generated/0_1_4/StoxReceiptVault.pointers.solis excluded by!**/generated/**src/generated/0_1_4/StoxUnifiedDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_4/StoxWrappedTokenVault.pointers.solis excluded by!**/generated/**src/generated/0_1_4/StoxWrappedTokenVaultBeacon.pointers.solis excluded by!**/generated/**src/generated/0_1_4/StoxWrappedTokenVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_5/ST0xOrchestrator.pointers.solis excluded by!**/generated/**src/generated/0_1_5/ST0xOrchestratorBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_5/StoxCorporateActionsFacet.pointers.solis excluded by!**/generated/**src/generated/0_1_5/StoxOffchainAssetReceiptVaultAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/0_1_5/StoxOffchainAssetReceiptVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_5/StoxOffchainAssetReceiptVaultPaymentMintAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/0_1_5/StoxReceipt.pointers.solis excluded by!**/generated/**src/generated/0_1_5/StoxReceiptVault.pointers.solis excluded by!**/generated/**src/generated/0_1_5/StoxUnifiedDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_5/StoxWrappedTokenVault.pointers.solis excluded by!**/generated/**src/generated/0_1_5/StoxWrappedTokenVaultBeacon.pointers.solis excluded by!**/generated/**src/generated/0_1_5/StoxWrappedTokenVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_6/ST0xOrchestrator.pointers.solis excluded by!**/generated/**src/generated/0_1_6/ST0xOrchestratorBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_6/StoxCorporateActionsFacet.pointers.solis excluded by!**/generated/**src/generated/0_1_6/StoxOffchainAssetReceiptVaultAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/0_1_6/StoxOffchainAssetReceiptVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_6/StoxOffchainAssetReceiptVaultPaymentMintAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/0_1_6/StoxReceipt.pointers.solis excluded by!**/generated/**src/generated/0_1_6/StoxReceiptVault.pointers.solis excluded by!**/generated/**src/generated/0_1_6/StoxUnifiedDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_6/StoxWrappedTokenVault.pointers.solis excluded by!**/generated/**src/generated/0_1_6/StoxWrappedTokenVaultBeacon.pointers.solis excluded by!**/generated/**src/generated/0_1_6/StoxWrappedTokenVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_7/ST0xOrchestrator.pointers.solis excluded by!**/generated/**src/generated/0_1_7/ST0xOrchestratorBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_7/StoxCorporateActionsFacet.pointers.solis excluded by!**/generated/**src/generated/0_1_7/StoxOffchainAssetReceiptVaultAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/0_1_7/StoxOffchainAssetReceiptVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_7/StoxOffchainAssetReceiptVaultPaymentMintAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/0_1_7/StoxReceipt.pointers.solis excluded by!**/generated/**src/generated/0_1_7/StoxReceiptVault.pointers.solis excluded by!**/generated/**src/generated/0_1_7/StoxUnifiedDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_7/StoxWrappedTokenVault.pointers.solis excluded by!**/generated/**src/generated/0_1_7/StoxWrappedTokenVaultBeacon.pointers.solis excluded by!**/generated/**src/generated/0_1_7/StoxWrappedTokenVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_8/ST0xOrchestrator.pointers.solis excluded by!**/generated/**src/generated/0_1_8/ST0xOrchestratorBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_8/StoxCorporateActionsFacet.pointers.solis excluded by!**/generated/**src/generated/0_1_8/StoxOffchainAssetReceiptVaultAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/0_1_8/StoxOffchainAssetReceiptVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_8/StoxOffchainAssetReceiptVaultPaymentMintAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/0_1_8/StoxReceipt.pointers.solis excluded by!**/generated/**src/generated/0_1_8/StoxReceiptVault.pointers.solis excluded by!**/generated/**src/generated/0_1_8/StoxUnifiedDeployer.pointers.solis excluded by!**/generated/**src/generated/0_1_8/StoxWrappedTokenVault.pointers.solis excluded by!**/generated/**src/generated/0_1_8/StoxWrappedTokenVaultBeacon.pointers.solis excluded by!**/generated/**src/generated/0_1_8/StoxWrappedTokenVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/LibProdDeployCurrent.solis excluded by!**/generated/**src/generated/LibProdDeployV4.solis excluded by!**/generated/**src/generated/candidate/ST0xOrchestrator.pointers.solis excluded by!**/generated/**src/generated/candidate/ST0xOrchestratorBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/candidate/StoxCorporateActionsFacet.pointers.solis excluded by!**/generated/**src/generated/candidate/StoxOffchainAssetReceiptVaultAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/candidate/StoxOffchainAssetReceiptVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**src/generated/candidate/StoxOffchainAssetReceiptVaultPaymentMintAuthorizerV1.pointers.solis excluded by!**/generated/**src/generated/candidate/StoxReceipt.pointers.solis excluded by!**/generated/**src/generated/candidate/StoxReceiptVault.pointers.solis excluded by!**/generated/**src/generated/candidate/StoxUnifiedDeployer.pointers.solis excluded by!**/generated/**src/generated/candidate/StoxWrappedTokenVault.pointers.solis excluded by!**/generated/**src/generated/candidate/StoxWrappedTokenVaultBeacon.pointers.solis excluded by!**/generated/**src/generated/candidate/StoxWrappedTokenVaultBeaconSetDeployer.pointers.solis excluded by!**/generated/**
📒 Files selected for processing (20)
.github/workflows/package-release.yamlfoundry.tomlscript/BuildPointers.solscript/Deploy.solscript/cut-release.shtest/lib/LibTestDeploy.soltest/src/concrete/ST0xOrchestrator.t.soltest/src/concrete/StoxReceiptVaultFallbackRouting.t.soltest/src/concrete/StoxWrappedTokenVault.t.soltest/src/concrete/StoxWrappedTokenVaultBeacon.t.soltest/src/concrete/StoxWrappedTokenVaultV2.t.soltest/src/concrete/deploy/ST0xOrchestratorBeaconSetDeployer.t.soltest/src/concrete/deploy/StoxProdV4.t.soltest/src/concrete/deploy/StoxUnifiedDeployer.newTokenAndWrapperVault.t.soltest/src/concrete/deploy/StoxUnifiedDeployer.t.soltest/src/concrete/deploy/StoxWrappedTokenVaultBeaconSetDeployer.t.soltest/src/concrete/integration/GuardHaltsAfterVaultBeaconUpgrade.t.soltest/src/concrete/integration/GuardPassesAgainstRealV4Beacons.t.soltest/src/concrete/integration/OrchestratorIntegrationTest.soltest/src/lib/LibProdDeployV4.t.sol
Deploys must be audited versions only. Deleted script/Deploy.sol (which deployed the rolling current source = candidate), its test, and the manual-sol-artifacts.yaml workflow that dispatched it. Dropped the now-dead LibStoxDeployNetworks.supportedNetworks() (kept the ETHEREUM/HYPEREVM constants the audited DeployProdV4_0_1_1.sol uses). Updated CLAUDE.md and stale comments to the audited-only deploy model. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploy is audited-versions-only — candidate is never a deploy target: - Delete script/Deploy.sol (deployed current source), test/script/Deploy.t.sol, and .github/workflows/manual-sol-artifacts.yaml. Keep the audited DeployProdV4_0_1_1.sol + manual-sol-artifacts-0-1-1.yaml. - LibStoxDeployNetworks: drop the now-dead supportedNetworks(); keep the ETHEREUM/HYPEREVM constants (audited script + fork tests use them). Update its test + scrub Deploy.sol/current-source NatSpec. - CLAUDE.md Deployment: rewrite to the audited model. PR#283 fixes: - cut-release.sh: add SPDX header (reuse lint); replace unconditional rm -rf with an append-only guard that aborts if the numbered snapshot already exists (never clobber a frozen/audited snapshot). - package-release.yaml: explicit secrets (not inherit) — exactly the set rainix-tag-release declares incl. the RPC_URL_*_FORK verify secrets; drop id-token (the reusable uses no OIDC), keep contents: write. - Scrub stale 0.1.3/0.1.2/twin references in the deploy test comments/strings to describe the rolling candidate snapshot; leave _CANDIDATE constant refs intact. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
script/cut-release.sh (1)
20-23: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winPreserve the intended missing-version diagnostic.
With
set -euo pipefail, a missing[package].versionmakes thegrepin the assignment fail before theif [ -z "$VERSION" ]branch can emit the diagnostic and exit.Proposed fix
-VERSION="$(grep -m1 -E '^version = ' foundry.toml | sed -E 's/^version = "([^"]+)"/\1/')" +if ! VERSION="$(grep -m1 -E '^version = ' foundry.toml | sed -E 's/^version = "([^"]+)"/\1/')"; then + echo "cut-release: could not read [package].version from foundry.toml" >&2 + exit 1 +fi if [ -z "$VERSION" ]; then🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@script/cut-release.sh` around lines 20 - 23, Update the VERSION assignment in cut-release.sh so a missing grep match does not terminate the script under set -euo pipefail before the existing empty-value check runs. Preserve the current diagnostic and exit behavior in the VERSION validation branch.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/src/concrete/deploy/StoxProdV4.t.sol`:
- Around line 192-207: Update checkAllV4OnChain so the Base-fork verification
uses only the frozen numbered release deployed on Base, removing its
candidate-specific contract/address assertions. Keep candidate snapshot
consistency validation confined to testCandidateSelfConsistent, and preserve the
existing released-version checks.
---
Outside diff comments:
In `@script/cut-release.sh`:
- Around line 20-23: Update the VERSION assignment in cut-release.sh so a
missing grep match does not terminate the script under set -euo pipefail before
the existing empty-value check runs. Preserve the current diagnostic and exit
behavior in the VERSION validation branch.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 26ae93a1-8c2c-44a5-b642-5a2307e5da38
📒 Files selected for processing (13)
.github/workflows/manual-sol-artifacts.yaml.github/workflows/package-release.yamlCLAUDE.mdscript/20260619-deploy-v4-authoriser-clone.s.solscript/Deploy.solscript/DeployProdV4_0_1_1.solscript/cut-release.shsrc/lib/LibStoxDeployNetworks.soltest/script/Deploy.t.soltest/src/concrete/ST0xOrchestrator.t.soltest/src/concrete/deploy/StoxProdV4.t.soltest/src/lib/LibProdDeployV4.t.soltest/src/lib/LibStoxDeployNetworks.t.sol
💤 Files with no reviewable changes (2)
- .github/workflows/manual-sol-artifacts.yaml
- script/Deploy.sol
The candidate model doesn't reset the version counter: Soldeer has published st0x-deploy through 0.1.29 (sol-v git tags likewise), so the next release is 0.1.30 — matching main's next-version slot. 0.1.1 is already published and can't be re-cut; it names only the frozen audited snapshot dir, not the package version. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- StoxProdV4.t.sol: remove the entire _CANDIDATE on-chain verification block from checkAllV4OnChain (it required candidate contracts to be deployed on a Base fork — a time-bomb, since candidate regenerates from source and is never a deploy target; it only passed incidentally because candidate==0_1_3==0_1_8 is Zoltu-deployed). Inline the sole callsite to checkProd_0_1_1OnChain() and delete the function; the Base fork now verifies only the frozen audited 0.1.1 set the in-use beacons actually adopt. candidate == current source is verified locally by testCandidateSelfConsistent, off-fork. Drop the now-unused Ownable and ST0xOrchestratorBeaconSetDeployer imports. checkProd_0_1_1OnChain and its _0_1_1 assertions untouched. - LibProdDeployV4.t.sol: reword the beacon-set-deployer frozen-redeploy comment (no beacon bytecode baked into the deployer artifact; the deployed proxy checks the beacon at proxy construction time). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… cut-release - manual-broadcast.yaml comments now reference manual-sol-artifacts-0-1-1.yaml (the surviving audited deploy workflow) instead of the deleted dispatcher. - BuildPointers buildContractPointers NatSpec describes the candidate model instead of the removed version-derived tag. - cut-release.sh refuses non-X.Y.Z versions, which would otherwise freeze an orphan snapshot dir the generator's numeric tag filter never picks up. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Reviewed 0f64809: approve Adversarial review + verification summary:
Merging with --admin over the intentional gate on the user's word. |
This was referenced Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The deploy repo had grown ten version-numbered snapshots (
0_1_1…0_1_11) andLibProdDeployCurrentpinned prod to0_1_8— but live production on Base runs the audited0.1.1(all three production beacons resolve to the0_1_1implementations on-chain, andDeployProdV4_0_1_1.soldeploys that set from stored creation code). The extra snapshots were bad-autopublish-workflow noise that made stale, never-adopted versions look deployable — a footgun. The repo was also on the wrong (autopublish) release lifecycle, leavingtestDeployTagpermanently red.The model
The current deployment snapshot is now an unnamed, rolling
src/generated/candidate/— always regenerated from source, so it is whatever the source compiles to.LibProdDeployCurrentand all source self-references point at it. A numbered snapshot is only ever cut when asol-vX.Y.Zgit tag freezes the candidate intosrc/generated/<version>/and publishes it. This means the source is always a self-consistent audit candidate: the instant auditors sign off a commit, you tag it, the candidate freezes into that version, and you deploy it.0_1_1/— kept, byte-identical (verified againstmain). The frozen audited snapshot = what's live (the 3 beacons) = whatDeployProdV4_0_1_1.soldeploys.candidate/— the current source (which sits ahead of0_1_1: the orchestrator, added post-audit, plus a corporate-actions change — all deployed on Base but not adopted by the production beacons). This "source-ahead-of-prod" reality is now modelled explicitly instead of hidden behind version noise.0_1_2…0_1_11snapshots (theirsol-v*tags are dropped separately).Changes
BuildPointers.sol: the current tag is the constantcandidate(not version-derived); onlycandidateis regenerated, numbered dirs stay frozen;candidatesorts last after the frozen releases.testDeployTag→testCandidateSelfConsistent: asserts each candidate contract's storedCREATION_CODE == type(C).creationCode(fails if source changes without regenerating the candidate). Plus thetestDeployAddress*suite deploys current source and asserts== candidate.package-release.yaml→rainix-tag-release(tag-triggered deploy-repo lifecycle, mirroringrain.factory.deploy); newscript/cut-release.shperforms the candidate→numbered freeze at release.script/Deploy.solrepointed_0_1_3 → _CANDIDATE; the multi-version chain tests (whose premise is gone) dropped.Verification
src/generated/0_1_1byte-identical tomain(audited snapshot frozen). ✓forge buildclean;forge fmt --checkclean.forge test: 525 passed (incl.testCandidateSelfConsistentand everytestDeployAddress*). The 24 failures are all RPC-environmental (publiceth.llamarpc.com521 / Base 429 rate-limit / missingARBITRUM|BASE_SEPOLIA|FLARE|POLYGON_RPC_URL) — none are assertion failures; they run in CI with the org RPC secrets.Notes
0_1_1is unchanged — so this is a repo-model change, not a deploy.sol-v*git tags are dropped as a separate landing step.Follow-up commit: deploy path is audited-only
Deploys must be audited versions only, so this branch also removes the current-source deploy path:
script/Deploy.sol(which deployed the rollingcandidate), its test, and themanual-sol-artifacts.yamlworkflow that dispatched it.LibStoxDeployNetworks.supportedNetworks(); kept theETHEREUM/HYPEREVMconstants the auditedDeployProdV4_0_1_1.soluses.DeployProdV4_0_1_1.sol(and a futureDeployProdV4_0_1_N.solper audited version).candidateis never a deploy target — only tests +testCandidateSelfConsistent.Summary by CodeRabbit
New Features
Refactor
Documentation