Skip to content

feat(tokens): add tSKHY/wtSKHY to the Base production token list - #263

Merged
thedavidmeister merged 1 commit into
mainfrom
feat/add-skhy-base-token
Jul 17, 2026
Merged

feat(tokens): add tSKHY/wtSKHY to the Base production token list#263
thedavidmeister merged 1 commit into
mainfrom
feat/add-skhy-base-token

Conversation

@hardyjosh

@hardyjosh hardyjosh commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Adds the 21st Base production token (SK hynix ADR, tSKHY/wtSKHY) to LibTokenInvariants — pins + productionReceiptVaults() — so the receipt-vault uniformity invariants and the V4 receipt-vault upgrade's setAuthorizer cover it. Verified live on Base (correct wiring, Safe-owned, on V3 pre-swap); LibTokenInvariantsTest passes with 21 vaults.

Summary by CodeRabbit

  • Bug Fixes
    • Expanded production receipt vault validation to include the SK hynix (SKHY) vault.
    • Consistency checks now cover all supported production receipt vaults.

Adds the 21st Base production token — SK hynix Inc. ADR ST0x (tSKHY/wtSKHY) —
to LibTokenInvariants: the receipt / receipt-vault / wrapped-token-vault pins
and the receipt vault into productionReceiptVaults(). So the receipt-vault
uniformity invariants cover it and the V4 receipt-vault upgrade
(20260623-upgrade-receipt-vaults-to-v4) sets the authoriser on it too (its
setAuthorizer tx count derives from productionReceiptVaults().length).

Verified live on Base: wtSKHY.asset() == receiptVault, receiptVault owned by
the token-owner Safe, on the V3 authoriser (pre-swap) like the other 20;
LibTokenInvariantsTest uniform owner + authoriser pass with 21 vaults.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VPs1hCTxusmaSeFKvoc4Kr
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 80d09357-76de-4753-9e0e-5b5f016eb1da

📥 Commits

Reviewing files that changed from the base of the PR and between 23c37f1 and 5a80937.

⛔ Files ignored due to path filters (12)
  • src/generated/0_1_11/ST0xOrchestrator.pointers.sol is excluded by !**/generated/**
  • src/generated/0_1_11/ST0xOrchestratorBeaconSetDeployer.pointers.sol is excluded by !**/generated/**
  • src/generated/0_1_11/StoxCorporateActionsFacet.pointers.sol is excluded by !**/generated/**
  • src/generated/0_1_11/StoxOffchainAssetReceiptVaultAuthorizerV1.pointers.sol is excluded by !**/generated/**
  • src/generated/0_1_11/StoxOffchainAssetReceiptVaultBeaconSetDeployer.pointers.sol is excluded by !**/generated/**
  • src/generated/0_1_11/StoxOffchainAssetReceiptVaultPaymentMintAuthorizerV1.pointers.sol is excluded by !**/generated/**
  • src/generated/0_1_11/StoxReceipt.pointers.sol is excluded by !**/generated/**
  • src/generated/0_1_11/StoxReceiptVault.pointers.sol is excluded by !**/generated/**
  • src/generated/0_1_11/StoxUnifiedDeployer.pointers.sol is excluded by !**/generated/**
  • src/generated/0_1_11/StoxWrappedTokenVault.pointers.sol is excluded by !**/generated/**
  • src/generated/0_1_11/StoxWrappedTokenVaultBeacon.pointers.sol is excluded by !**/generated/**
  • src/generated/0_1_11/StoxWrappedTokenVaultBeaconSetDeployer.pointers.sol is excluded by !**/generated/**
📒 Files selected for processing (1)
  • src/lib/LibTokenInvariants.sol

📝 Walkthrough

Walkthrough

The production receipt vault invariant universe expands from 20 to 21 entries by adding the SK hynix receipt vault, allowing existing owner and authoriser checks to include it.

Changes

SKHY vault coverage

Layer / File(s) Summary
Expand production vault roster
src/lib/LibTokenInvariants.sol
Adds SKHY vault constants, increases the roster allocation to 21 entries, and assigns SKHY_RECEIPT_VAULT to the final slot.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Poem

A bunny hops where vaults align,
Twenty become twenty-one in line.
SKHY joins the invariant crew,
Owner and authoriser checks now too.
Carrots for every vault—hooray! 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding the SKHY token to the Base production token list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/add-skhy-base-token

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thedavidmeister
thedavidmeister merged commit 9b48639 into main Jul 17, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants