Remove unused methods and constructors across various classes - #1751
Draft
CaiJimmy wants to merge 7 commits into
Draft
Remove unused methods and constructors across various classes#1751CaiJimmy wants to merge 7 commits into
CaiJimmy wants to merge 7 commits into
Conversation
- Removed clearUserDefinedFunctions method from NamedFunctions. - Eliminated default constructor from StaticContext, VariableValues, and several item classes (e.g., MapEntryItem, SequenceArrayItem). - Deleted unused methods such as getQName from NameTest, getValue from DecimalItem, and others from various classes. - Cleaned up TryCatchExpression and TryCatchStatement by removing catchesAll and related methods. - Removed unnecessary getters and setters in Facets and other item types. - Streamlined code by removing redundant methods in runtime iterators and expression classes.
CaiJimmy
marked this pull request as ready for review
July 28, 2026 10:15
QT3 Test Results - Parser:
|
| Test Suite | Passing | Failing | Errors | Skipped | Total |
|---|---|---|---|---|---|
app |
1983 | 39 | 120 | 15 | 2157 |
array |
207 | 0 | 1 | 1 | 209 |
fn |
9911 | 480 | 219 | 525 | 11135 |
map |
220 | 0 | 0 | 0 | 220 |
math |
149 | 0 | 0 | 0 | 149 |
misc |
698 | 73 | 32 | 68 | 871 |
op |
4119 | 72 | 103 | 72 | 4366 |
prod |
9828 | 547 | 409 | 1423 | 12207 |
ser |
321 | 21 | 1 | 0 | 343 |
xs |
147 | 6 | 0 | 11 | 164 |
| Total | 27583 | 1238 | 885 | 2115 | 31821 |
Full analysis report: see analysis-jsoniq in artifacts.
QT3 Test Results - Parser:
|
| Test Suite | Passing | Failing | Errors | Skipped | Total |
|---|---|---|---|---|---|
app |
2023 | 38 | 89 | 7 | 2157 |
array |
207 | 0 | 1 | 1 | 209 |
fn |
9965 | 451 | 221 | 498 | 11135 |
map |
220 | 0 | 0 | 0 | 220 |
math |
149 | 0 | 0 | 0 | 149 |
misc |
720 | 64 | 27 | 60 | 871 |
op |
4242 | 23 | 60 | 41 | 4366 |
prod |
10583 | 432 | 346 | 846 | 12207 |
ser |
343 | 0 | 0 | 0 | 343 |
xs |
153 | 0 | 0 | 11 | 164 |
| Total | 28605 | 1008 | 744 | 1464 | 31821 |
Full analysis report: see analysis-xquery in artifacts.
CaiJimmy
marked this pull request as draft
July 28, 2026 10:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still many unused classes and exceptions in the codebase that I did not touch, just in case.
Unused classes: