Create PartialFunctionCallIterator to centralize the logic of partial functions - #1514
Open
CaiJimmy wants to merge 8 commits into
Open
Create PartialFunctionCallIterator to centralize the logic of partial functions#1514CaiJimmy wants to merge 8 commits into
CaiJimmy wants to merge 8 commits into
Conversation
QT3 Test Results - Parser:
|
| Suite | Test file | Test case |
|---|---|---|
fn |
fn/function-name.xml:fn-function-name-023 |
|
misc |
misc/HigherOrderFunctions.xml:xqhof8 |
|
misc |
misc/HigherOrderFunctions.xml:xqhof9 |
|
prod |
prod/VersionDecl.xml:K2-VersionProlog-3-v4 |
Summary of passed tests for jsoniq
| Test Suite | Passing | Failing | Errors | Skipped | Total |
|---|---|---|---|---|---|
app |
1464 | 50 | 179 | 464 | 2157 |
array |
164 | 18 | 17 | 10 | 209 |
fn |
7459 | 1088 | 1257 | 1331 | 11135 |
map |
181 | 34 | 2 | 3 | 220 |
math |
149 | 0 | 0 | 0 | 149 |
misc |
231 | 332 | 133 | 175 | 871 |
op |
4006 | 135 | 122 | 103 | 4366 |
prod |
7871 | 937 | 1169 | 2230 | 12207 |
ser |
35 | 213 | 19 | 76 | 343 |
xs |
103 | 14 | 4 | 43 | 164 |
| Total | 21663 | 2821 | 2902 | 4435 | 31821 |
Full analysis report: see analysis-jsoniq in artifacts.
QT3 Test Results - Parser:
|
| Suite | Test file | Test case |
|---|---|---|
fn |
fn/function-name.xml:fn-function-name-023 |
|
misc |
misc/HigherOrderFunctions.xml:xqhof8 |
|
misc |
misc/HigherOrderFunctions.xml:xqhof9 |
|
prod |
prod/VersionDecl.xml:K2-VersionProlog-3-v4 |
|
prod |
prod/VersionDecl.xml:K2-VersionProlog-6 |
Summary of passed tests for xquery
| Test Suite | Passing | Failing | Errors | Skipped | Total |
|---|---|---|---|---|---|
app |
1674 | 88 | 362 | 33 | 2157 |
array |
182 | 0 | 18 | 9 | 209 |
fn |
7609 | 1258 | 1436 | 832 | 11135 |
map |
210 | 8 | 2 | 0 | 220 |
math |
149 | 0 | 0 | 0 | 149 |
misc |
259 | 338 | 137 | 137 | 871 |
op |
4141 | 90 | 94 | 41 | 4366 |
prod |
8756 | 1102 | 1387 | 962 | 12207 |
ser |
40 | 258 | 45 | 0 | 343 |
xs |
99 | 18 | 4 | 43 | 164 |
| Total | 23119 | 3160 | 3485 | 2057 | 31821 |
Full analysis report: see analysis-xquery in artifacts.
…y/dynamic-partial
CaiJimmy
marked this pull request as ready for review
June 17, 2026 13:45
ghislainfourny
approved these changes
Jun 19, 2026
Member
There was a problem hiding this comment.
Very nicely architectured!
A minor hint: perhaps rename FunctionCallIterator to StaticFunctionCallIterator and PartialFunctionCallIterator to StaticPartialFunctionCallIterator to make clear that partial dynamic function calls are (already) covered by the dynamic function call iterator?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.