Skip to content

chore(models): remove obsolete notification indexes#41336

Open
AlgoArtist06 wants to merge 1 commit into
RocketChat:developfrom
AlgoArtist06:fix/41318-remove-obsolete-subscription-indexes
Open

chore(models): remove obsolete notification indexes#41336
AlgoArtist06 wants to merge 1 commit into
RocketChat:developfrom
AlgoArtist06:fix/41318-remove-obsolete-subscription-indexes

Conversation

@AlgoArtist06

@AlgoArtist06 AlgoArtist06 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

  • remove the stale compatibility TODO for the subscription notification-preference indexes
  • remove the commented-out desktopNotifications, mobilePushNotifications, and emailNotifications index declarations now that their consumers are gone

Closes #41318

Changeset

No changeset is required because this is internal comment cleanup only; it does not change runtime behavior or the published package API.

Testing

  • yarn turbo run build --filter=@rocket.chat/models...
  • yarn workspace @rocket.chat/models lint (passes with existing warnings)
  • yarn workspace @rocket.chat/models typecheck
  • yarn workspace @rocket.chat/models test --runInBand (2 suites, 16 tests)

@AlgoArtist06
AlgoArtist06 requested a review from a team as a code owner July 13, 2026 11:46
@dionisio-bot

dionisio-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@CLAassistant

CLAassistant commented Jul 13, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@changeset-bot

changeset-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: aab9070

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Removes a TODO and commented-out deprecated index definitions from the subscription model’s MongoDB index list. No active index or query behavior changes.

Changes

Subscription index cleanup

Layer / File(s) Summary
Remove obsolete index comments
packages/models/src/models/Subscriptions.ts
Removes the deprecated commented-out notification index definitions and their TODO from SubscriptionsRaw.modelIndexes().

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR removes the obsolete desktop, mobile, and email notification index declarations requested in #41318.
Out of Scope Changes check ✅ Passed The change stays focused on deleting the stale index declarations and TODO, with no unrelated code added.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing obsolete notification indexes from the models package.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@AlgoArtist06

Copy link
Copy Markdown
Contributor Author

Reviewed the automated feedback. CodeRabbit reported no actionable comments and all of its pre-merge checks passed. This PR only removes stale comments, so it does not require a changeset or package version bump. The CLA signature and upstream-managed QA/milestone metadata remain as workflow gates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove these indexes in the next major release (8.0.0) - their only consumers (the per-room notification-preference finders) were removed

2 participants