chore(models): remove obsolete notification indexes#41336
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
WalkthroughRemoves a TODO and commented-out deprecated index definitions from the subscription model’s MongoDB index list. No active index or query behavior changes. ChangesSubscription index cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reviewed the automated feedback. CodeRabbit reported no actionable comments and all of its pre-merge checks passed. This PR only removes stale comments, so it does not require a changeset or package version bump. The CLA signature and upstream-managed QA/milestone metadata remain as workflow gates. |
Proposed changes
desktopNotifications,mobilePushNotifications, andemailNotificationsindex declarations now that their consumers are goneCloses #41318
Changeset
No changeset is required because this is internal comment cleanup only; it does not change runtime behavior or the published package API.
Testing
yarn turbo run build --filter=@rocket.chat/models...yarn workspace @rocket.chat/models lint(passes with existing warnings)yarn workspace @rocket.chat/models typecheckyarn workspace @rocket.chat/models test --runInBand(2 suites, 16 tests)