refactor: revamp admin settings group template#41331
refactor: revamp admin settings group template#41331devin-ai-integration[bot] wants to merge 5 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
🦋 Changeset detectedLatest commit: a2a68bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41331 +/- ##
===========================================
+ Coverage 69.04% 69.09% +0.04%
===========================================
Files 3757 3759 +2
Lines 147735 147898 +163
Branches 26395 26428 +33
===========================================
+ Hits 102000 102183 +183
+ Misses 41234 41226 -8
+ Partials 4501 4489 -12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
… in-page TOC Replace bespoke Accounts page with a refactor of the shared settings template so all groups get card-based sections, header Reset/Save changes, and an in-page table of contents. Existing setting names and descriptions are preserved. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Proposed changes (including videos or screenshots)
Revamps the shared admin settings group template so the redesigned look applies to every settings group automatically, rather than adding a new bespoke page. Existing setting names and descriptions are untouched — this is a presentation-layer refactor of the components used by
/admin/settings/:group.What changed:
SettingsSection— renders each section as an always-visible bordered card (Box is='section'with a stable anchorid) instead of a collapsibleAccordionItem. The section title becomes a heading inside the card; the per-section reset button and setting rendering are preserved.SettingsGroupPage— replaces the<Accordion>wrapper with a two-column flex layout: a scrollable stack of section cards on the left and an in-page table of contents on the right. TheReset(previously the footerCancel) andSave changesactions move from thePageFooterinto thePageHeader;PageFooteris removed. Save/reset handlers and dirty/disabled logic are unchanged.SettingsPageTableOfContents(new) — right-side "Settings in<group>" nav listing the group's sections. Clicking scrolls to the section (scrollIntoView); the active section is highlighted via anIntersectionObserverscroll-spy. Rendered only when a group has more than one named section.getSectionAnchorId(groupId, sectionName)(new util) — shared anchor id used by both the section cards and the TOC entries so scroll targets stay in sync.GenericGroupPageandOAuthGroupPagenow pass theirsectionslist down toSettingsGroupPagefor the TOC. Tabbed groups pass the current tab's sections.Because sections are no longer collapsible, one e2e step that clicked the "Custom CSS" accordion to reveal the editor was removed (the editor is now always visible).
Note: this supersedes the earlier bespoke
/admin/accountspage approach, which has been fully reverted in this PR.Issue(s)
N/A
Steps to test or reproduce
/admin/settingsand open any group (e.g. Accounts, General, Layout).<group>" list on the right.Save changes(header) enables;Resetdiscards unsaved edits; saving shows the "Settings updated" toast.Further comments
The refactor keeps all existing settings behavior (edit/save/reset, per-section reset, enterprise/visibility handling) and only changes layout/presentation, so it applies uniformly across every settings group.
Link to Devin session: https://app.devin.ai/sessions/7e89039a99d448a79707714fe7f2ac85
Requested by: @rodrigok