Skip to content

refactor: revamp admin settings group template#41331

Draft
devin-ai-integration[bot] wants to merge 5 commits into
developfrom
devin/1783890483-accounts-admin-revamp
Draft

refactor: revamp admin settings group template#41331
devin-ai-integration[bot] wants to merge 5 commits into
developfrom
devin/1783890483-accounts-admin-revamp

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jul 12, 2026

Copy link
Copy Markdown

Proposed changes (including videos or screenshots)

Revamps the shared admin settings group template so the redesigned look applies to every settings group automatically, rather than adding a new bespoke page. Existing setting names and descriptions are untouched — this is a presentation-layer refactor of the components used by /admin/settings/:group.

What changed:

  • SettingsSection — renders each section as an always-visible bordered card (Box is='section' with a stable anchor id) instead of a collapsible AccordionItem. The section title becomes a heading inside the card; the per-section reset button and setting rendering are preserved.
  • SettingsGroupPage — replaces the <Accordion> wrapper with a two-column flex layout: a scrollable stack of section cards on the left and an in-page table of contents on the right. The Reset (previously the footer Cancel) and Save changes actions move from the PageFooter into the PageHeader; PageFooter is removed. Save/reset handlers and dirty/disabled logic are unchanged.
  • SettingsPageTableOfContents (new) — right-side "Settings in <group>" nav listing the group's sections. Clicking scrolls to the section (scrollIntoView); the active section is highlighted via an IntersectionObserver scroll-spy. Rendered only when a group has more than one named section.
  • getSectionAnchorId(groupId, sectionName) (new util) — shared anchor id used by both the section cards and the TOC entries so scroll targets stay in sync.
  • Wiring: GenericGroupPage and OAuthGroupPage now pass their sections list down to SettingsGroupPage for the TOC. Tabbed groups pass the current tab's sections.

Because sections are no longer collapsible, one e2e step that clicked the "Custom CSS" accordion to reveal the editor was removed (the editor is now always visible).

Note: this supersedes the earlier bespoke /admin/accounts page approach, which has been fully reverted in this PR.

Issue(s)

N/A

Steps to test or reproduce

  1. Go to /admin/settings and open any group (e.g. Accounts, General, Layout).
  2. Sections render as cards, all expanded, with a "Settings in <group>" list on the right.
  3. Click a TOC entry → the page scrolls to that section and the entry highlights; scrolling updates the active entry.
  4. Change a setting → Save changes (header) enables; Reset discards unsaved edits; saving shows the "Settings updated" toast.

Further comments

The refactor keeps all existing settings behavior (edit/save/reset, per-section reset, enterprise/visibility handling) and only changes layout/presentation, so it applies uniformly across every settings group.

Link to Devin session: https://app.devin.ai/sessions/7e89039a99d448a79707714fe7f2ac85
Requested by: @rodrigok

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@rodrigok rodrigok self-assigned this Jul 12, 2026
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@changeset-bot

changeset-bot Bot commented Jul 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a2a68bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot

dionisio-bot Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.09%. Comparing base (edbaeef) to head (a2a68bd).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #41331      +/-   ##
===========================================
+ Coverage    69.04%   69.09%   +0.04%     
===========================================
  Files         3757     3759       +2     
  Lines       147735   147898     +163     
  Branches     26395    26428      +33     
===========================================
+ Hits        102000   102183     +183     
+ Misses       41234    41226       -8     
+ Partials      4501     4489      -12     
Flag Coverage Δ
unit 70.63% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rodrigok and others added 3 commits July 12, 2026 21:21
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
… in-page TOC

Replace bespoke Accounts page with a refactor of the shared settings template so all groups get card-based sections, header Reset/Save changes, and an in-page table of contents. Existing setting names and descriptions are preserved.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration devin-ai-integration Bot changed the title feat: revamp Accounts administration page refactor: revamp admin settings group template Jul 13, 2026
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant