chore(ci): trim redundant work from CI critical path#41321
Conversation
- packages-build no longer waits on notify-draft-services (no output consumed; the notify job is a no-op outside release events but sat in the critical path of every PR/develop run) - test-federation-matrix restores the prebuilt packages artifact instead of re-running a full yarn build on a fresh runner - drop the now-unused turbo-build artifact upload (only federation-matrix consumed it) - align caching-for-turbo to v2.5.0 in meteor-build so it shares the same cache namespace as the other jobs
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41321 +/- ##
===========================================
- Coverage 69.06% 69.04% -0.03%
===========================================
Files 3755 3755
Lines 147612 147612
Branches 26431 26373 -58
===========================================
- Hits 101947 101916 -31
- Misses 41170 41199 +29
- Partials 4495 4497 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Reduce CI resource usage and wall-clock time by cutting redundant work. No test coverage or build outputs change.
Changes
1.
packages-buildno longer waits onnotify-draft-servicesnotify-draft-servicesonly does real work onreleaseevents (registers a draft on the cloud). On every PR /developpush it was a checkout + skipped step, yet it sat in the critical path blockingpackages-build. It produces no output thatpackages-buildconsumes. Dropped fromneeds, so package build starts right afterrelease-versions.2.
test-federation-matrixrestores the prebuilt packages artifactIt was running a full
yarn buildon a fresh runner instead of usingrestore-packages(untar the artifactpackages-buildalready produced) like every other test job. Swapped torestore-packages.3. Removed the now-unused
turbo-buildartifact uploadOnly
test-federation-matrixconsumed it (via the turbo cache download it no longer needs). Removing the upload saves artifact storage + upload time on every run.4. Aligned
caching-for-turboto v2.5.0 inmeteor-buildIt was pinned to v2.3.13 while every other job used v2.5.0 — different versions namespace their cache separately, so
meteor-buildwas missing cache the other jobs populated.Impact
Not included (bigger levers, discuss separately)
pr-*images.test-ui/test-ui-eesharding (4 + 5 shards) dominates wall-clock.