Skip to content

chore(ci): trim redundant work from CI critical path#41321

Draft
ggazzo wants to merge 1 commit into
developfrom
chore/optimize-ci-resources
Draft

chore(ci): trim redundant work from CI critical path#41321
ggazzo wants to merge 1 commit into
developfrom
chore/optimize-ci-resources

Conversation

@ggazzo

@ggazzo ggazzo commented Jul 11, 2026

Copy link
Copy Markdown
Member

Reduce CI resource usage and wall-clock time by cutting redundant work. No test coverage or build outputs change.

Changes

1. packages-build no longer waits on notify-draft-services
notify-draft-services only does real work on release events (registers a draft on the cloud). On every PR / develop push it was a checkout + skipped step, yet it sat in the critical path blocking packages-build. It produces no output that packages-build consumes. Dropped from needs, so package build starts right after release-versions.

2. test-federation-matrix restores the prebuilt packages artifact
It was running a full yarn build on a fresh runner instead of using restore-packages (untar the artifact packages-build already produced) like every other test job. Swapped to restore-packages.

3. Removed the now-unused turbo-build artifact upload
Only test-federation-matrix consumed it (via the turbo cache download it no longer needs). Removing the upload saves artifact storage + upload time on every run.

4. Aligned caching-for-turbo to v2.5.0 in meteor-build
It was pinned to v2.3.13 while every other job used v2.5.0 — different versions namespace their cache separately, so meteor-build was missing cache the other jobs populated.

Impact

  • Shorter critical path on every PR/develop run (one fewer job to wait on before builds start).
  • No full package rebuild in the federation job.
  • Less artifact upload/storage per run.

Not included (bigger levers, discuss separately)

  • Docker matrix still builds arm64 + amd64 for every microservice on PRs, though e2e only consumes amd64 — kept both arches to avoid changing published pr-* images.
  • test-ui / test-ui-ee sharding (4 + 5 shards) dominates wall-clock.

Review in cubic

- packages-build no longer waits on notify-draft-services (no output
  consumed; the notify job is a no-op outside release events but sat in
  the critical path of every PR/develop run)
- test-federation-matrix restores the prebuilt packages artifact instead
  of re-running a full yarn build on a fresh runner
- drop the now-unused turbo-build artifact upload (only federation-matrix
  consumed it)
- align caching-for-turbo to v2.5.0 in meteor-build so it shares the same
  cache namespace as the other jobs
@dionisio-bot

dionisio-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 67be608

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 62a6ac98-be17-4ed0-8665-850f1ce12068

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.04%. Comparing base (582d25d) to head (67be608).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #41321      +/-   ##
===========================================
- Coverage    69.06%   69.04%   -0.03%     
===========================================
  Files         3755     3755              
  Lines       147612   147612              
  Branches     26431    26373      -58     
===========================================
- Hits        101947   101916      -31     
- Misses       41170    41199      +29     
- Partials      4495     4497       +2     
Flag Coverage Δ
unit 70.49% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant