Skip to content

Fix error catching in str_to_int() #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nightriff wants to merge 3 commits into
base: feature/gltf-export
Choose a base branch
from
Open

Fix error catching in str_to_int() #87

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f968cf2
int() throws a ValueError, not a TypeError
Nightriff May 28, 2025
06bf829
Merge branch 'feature/gltf-export' into fix/str_to_int_catches_wrong_…
Nightriff May 28, 2025
b9a4ec4
Catch both errors and document the scenarios they're thrown
Nightriff Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/str_to_int.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ def str_to_int(string, *, default=None):
"""Returns the integer value of the string if the string is numeric,
otherwise returns default"""
try:
# TypeError is raised when the string is None.
# ValueError is raised when the string is not numeric.
return int(string)
except TypeError:
except (ValueError, TypeError):
return default