Skip to content

UIBLOX-3856 Compile an rbxasset binary#9

Draft
vocksel wants to merge 6 commits into
mainfrom
UIBLOX-3856-compile-to-binary
Draft

UIBLOX-3856 Compile an rbxasset binary#9
vocksel wants to merge 6 commits into
mainfrom
UIBLOX-3856-compile-to-binary

Conversation

@vocksel

@vocksel vocksel commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Depends on #5

@RobloxBuilderAI RobloxBuilderAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

BuilderAI automatically learns from your feedback.
React to inline comments below with 👍 👎 to indicate quality and leave a reply to provide contextualized feedback.

Learn more about BuilderAI Code Review agent here

BuilderAI can make mistakes, please review the changes thoroughly

Comment thread src/cli/commands/publish.luau Outdated
@@ -0,0 +1,41 @@
local cli = require("@pkg/cli")

local parseApiKey = require("@root/cli/parsers/parseProjectPath")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publish command imports parseApiKey from parseProjectPath, so the API key parser actually resolves a filesystem path instead of reading the api-key flag or environment variable.

Why this comment?parseApiKey is required from the project-path parser module (line 3). As a result, when parseApiKey(args, "api-key") is called, it will return the current working directory or throw a "project not found" error instead of returning the API key. Publishing will therefore always use the wrong credentials and likely fail even when an API key is provided.

💡 Fix with Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants