UIBLOX-3856 Compile an rbxasset binary#9
Draft
vocksel wants to merge 6 commits into
Draft
Conversation
RobloxBuilderAI
left a comment
There was a problem hiding this comment.
Tip
BuilderAI automatically learns from your feedback.
React to inline comments below with 👍 👎 to indicate quality and leave a reply to provide contextualized feedback.
Learn more about BuilderAI Code Review agent here
BuilderAI can make mistakes, please review the changes thoroughly
| @@ -0,0 +1,41 @@ | |||
| local cli = require("@pkg/cli") | |||
|
|
|||
| local parseApiKey = require("@root/cli/parsers/parseProjectPath") | |||
There was a problem hiding this comment.
The publish command imports parseApiKey from parseProjectPath, so the API key parser actually resolves a filesystem path instead of reading the api-key flag or environment variable.
Why this comment?
parseApiKey is required from the project-path parser module (line 3). As a result, when parseApiKey(args, "api-key") is called, it will return the current working directory or throw a "project not found" error instead of returning the API key. Publishing will therefore always use the wrong credentials and likely fail even when an API key is provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #5