Fix pre-existing CI failures: domain-migration cookie + stale key test fixtures - #93
Merged
Merged
Conversation
/auth/domain-migrate only ever runs on the pre-cutover domain, where a signed-in visitor still carries the legacy axion_session cookie — reading the renamed SESSION_COOKIE there (from the Lumen/Veil->Fresco/Glyph + Axion->Sennoric rename) meant it could never find that user, silently breaking the whole migration handoff. Also updates two sandbox-route tests that hardcoded the pre-rename axion-sk- key prefix as literal test data; every real key-minting/checking code path already consistently uses sennoric-sk-, so this is just stale test fixtures, not a backward-compat gap. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the 4 tests that were failing on master after PR #90 merged, blocking Deploy:
/auth/domain-migratewas reading the renamedsennoric_sessioncookie, but this endpoint only ever runs on the pre-cutover domain, where a signed-in visitor still carries the legacyaxion_sessioncookie. This silently broke the entire cross-domain session handoff — a real production bug from the rename, not a test issue.sandbox-route.test.mjstests hardcoded the pre-renameaxion-sk-key prefix as literal test data. Production key minting/checking already consistently usessennoric-sk-everywhere (verified via grep across index.js) — no backward-compat gap, just stale fixtures.Test plan
npm test: 259/259 passing (was 255/259)node --check src/index.js🤖 Generated with Claude Code