feat: add setAriaTypeName method for Fields#10154
Open
mikeharv wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
PR: feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes
Proposed Changes
This adds a setter for
Field.ariaTypeName, which is protected.Reason for Changes
Previously, it was only possible to set
ariaTypeNameby passing a string for it as part of theFieldconstructor'sconfigparameter.Test Coverage
Added a new test to confirm that the custom type name shows up in the computed aria label.
Documentation
Additional Information