chore: moved theme plugins into monorepo#10148
Draft
lizschwab wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7762
Proposed Changes
Reason for Changes
Test Coverage
Documentation
Additional Information
In its current state themes will not build or run. If we update the
blocklypackage.json exports to include the/distfolder in the front of the paths( see example below), the themes will build and run but blockly tests will fail and it would likely fail to resolve for anyone attempting to use the package if it were to be published that way.Example of how to update
packages/blockly/package.json:A more detailed list of what does and does not work with each version of the blockly package.json:
Needs /dist in exports to work:
Needs exports as-is:
Works in both:
TODO
[ ] Resolve issue around
/distfolder[ ] Clarify what workspace-notation looks like for dependencies