Skip to content
This repository was archived by the owner on Jun 23, 2026. It is now read-only.

fix: allow menu shortcut to override existing one - #792

Merged
maribethb merged 1 commit into
RaspberryPiFoundation:mainfrom
maribethb:enter-shortcut
Mar 31, 2026
Merged

maribethb merged 1 commit into
RaspberryPiFoundation:mainfrom
maribethb:enter-shortcut

Conversation

@maribethb

Copy link
Copy Markdown
Collaborator

Fixes RaspberryPiFoundation/blockly#9652

Allows the menu shortcut in the plugin to override any in core if present, making the plugin compatible with v12.5+ of blockly

Since the menu shortcut here will return true if the menu is actually opened, this will tell the shortcut system that it has been "handled" and thus the one in core will not fire

Updates the dev version of Blockly to 12.5.1 to test compatibility with latest

@maribethb
maribethb merged commit e1043e3 into RaspberryPiFoundation:main Mar 31, 2026
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@blockly/keyboard-navigation broken by Blockly version 12.5.0

2 participants