Fix messageWidth calculation for messages displayed in large font - #2231
Merged
Conversation
Ralim
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix.
For 128x32 OLED resolution,
messageWidthassumes that all messages are displayed in a small font. However for warning messages, the message string is prepended with0x01which tellsOLED::printto select large font. This results into an issue that warning messages do not auto scroll to the ending of the message. This issue was discovered while attempting to perform CJC calibration, the warning message didn't display the "...room temperature!" part.Warning messages auto scroll to the ending of the message text.