Repository navigation
Add Stopwatch plugin to the store - #509
Merged
Merged
Conversation
Owner
|
Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Stopwatch (
stopwatch) to the Plugin Store.What it does
IAnimatedDisplayCommand, a frame is only pushed when the picture changedany)One thing to flag: hold-to-reset
The SDK reports presses but not releases. To tell a hold from a tap, the plugin reads the host's ambient
TriggerPressScope.Current(the press token the macro engine uses for "wait until trigger released") via reflection and awaits itsReleasedtask. Every step is guarded: if the type or its members change, the button falls back to plain tap-to-toggle,Stopwatch.Resetkeeps working, and the plugin logs on load which mode is active.If you would rather not have plugins depend on that, an official release signal in the SDK (for example a task on
CommandContextthat completes when the triggering press ends) would let me drop the reflection. Happy to switch.