Skip to content

fix(mb_caa_dimensions): account for dimensions text in default MB cover art size reservation to prevent layout shifts #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arsinclair wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(mb_caa_dimensions): account for dimensions text in default MB cover art size reservation to prevent layout shifts #901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/mb_caa_dimensions/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ div.thumb-position {
}
}

// Reserve space for dimension labels below sidebar cover art (MB default is 218px).
#sidebar .cover-art.present {
min-height: 244px;
}

// Styling of the info spans
// TODO: beta.MBS of May 24 2024 changed the classname from "cover-art-image" to "artwork-image".
// Change this when new class name lands in production MBS.
Expand Down