CI: resolve container Python for release builds - #4624
Draft
gyohuangxin wants to merge 3 commits into
Draft
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release GitHub Actions workflow to locate a usable Python executable inside “legacy” (non-manylinux) build containers and then consistently use that interpreter for pip installs and wheel builds, improving compatibility with custom containers that don’t expose pip/python3 on PATH.
Changes:
- Add a “Resolve container Python (legacy)” step that finds a Python interpreter with
pipavailable and exports it asCONTAINER_PYTHON. - Switch legacy dependency installation steps from
pip ...to"${CONTAINER_PYTHON}" -m pip .... - Build legacy wheels using the resolved Python rather than hardcoding
python3.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+232
to
+239
| for candidate in /opt/venv/bin/python python3 python; do | ||
| if [ -x "$candidate" ]; then | ||
| py="$candidate" | ||
| elif command -v "$candidate" >/dev/null 2>&1; then | ||
| py="$(command -v "$candidate")" | ||
| else | ||
| continue | ||
| fi |
gyohuangxin
marked this pull request as draft
August 7, 2026 08:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-m pipfor legacy dependency installation stepsrocm/ufb-privatethat do not exposepip/python3likerocm/pytorchTesting