feat(noctalia): Migrate to Noctalia - #56
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d094451e07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d094451 to
0d1ed3f
Compare
0d1ed3f to
462d63c
Compare
RAPSNX
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9834874ebf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cdaa7843ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e55a5390b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1e55a53 to
29e02ed
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29e02edcc0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb7d155de0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bb7d155 to
59721b6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68c5af6ca2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcf8332352
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a65a5ade7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f51952904d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93343e6e2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
93343e6 to
1d2fb53
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d2fb534a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "SUPER,period, exec, rofimoji --action copy type" | ||
|
|
||
| # Reload kanshi | ||
| "SUPER,period, exec, noctalia msg panel-toggle launcher /emo " |
There was a problem hiding this comment.
Fresh evidence after the earlier comment is that the added trailing space remains unquoted: when Hyprland executes this command through the shell, normal shell parsing discards that whitespace and passes /emo, while settings/shell.nix still requires the /emo prefix. Thus Super+. continues to open an ordinary query instead of activating the emoji provider; quote the complete query argument so the space is included in argv.
Useful? React with 👍 / 👎.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 similar comment
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
c970d0a to
1e4820f
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1e4820f to
875cdf4
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
875cdf4 to
5889400
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58894005b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "[ workspace special:aux silent ] sleep 2 && chromium --profile-directory=Default --app-id=dlgohinmglaoopaiplliaecdpmnepmga" | ||
| ] | ||
| ++ cfg.autostart; | ||
| ]; |
There was a problem hiding this comment.
When either Hyprland session starts, this fixed exec-once list no longer includes the former per-host commands: Firefly loses Mumble, Firefox, and Chromium startup, while Zion loses Firefox and its ddcutil input-selection command. I checked both host files and the repository-wide autostart configuration; xdg.autostart.enable was added, but no equivalent desktop entries were added for these commands, so they no longer run after login.
Useful? React with 👍 / 👎.
79d7af7 to
6aa47c6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6aa47c69dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| 2. **Revert Home Manager configuration** in `hosts/firefly/home.nix`: | ||
| - Set `roles.desktop.hyprland.configOnly = true;` under `roles.desktop.hyprland`. | ||
| - Remove or disable `xdg.portal` and `systemd.user.services.xdg-desktop-portal*` overrides so systemd user units fall back to host `/usr/lib/systemd/user/` definitions. |
There was a problem hiding this comment.
When a Firefly user follows this rollback, the named systemd.user.services.xdg-desktop-portal* overrides do not exist; the Nix portal units are actually supplied by systemd.user.packages in hosts/firefly/home.nix:123-127. Leaving that list in place both retains the Nix frontend/GTK units instead of the promised /usr/libexec stack and, after configOnly = true forces finalPortalPackage to null, can make sw-fly fail evaluation. Instruct the user to remove or guard the package-unit list as part of the rollback.
Useful? React with 👍 / 👎.
Fix session isolation and logout crash trigger (phase 1+2) Resolve service duplication and clean portal routing (phase 2) docs: track completion of phase 1 and 2 tasks Migrate portal ownership and declarative config to HM (phase 3) - Relocate generic-Linux portal packages to hyprland module - Migrate xdph.conf to wayland.windowManager.hyprland.xdph.settings with 60 FPS cap - Express PATH via systemd.user.sessionVariables - Narrow systemd imported environment variables - Remove unused hyprland-git flake input - docs: track completion of phase 3 tasks Update documentation and finalize screencopy performance decisions (phase 4) - Document explicit Nix vs Ubuntu ownership boundaries - Update portal discovery documentation for modern XDG data dir lookup - Detail package unit symlink cleanup in rollback procedures - Confirm screencopy performance decision to retain automatic fallback - docs: track completion of phase 4 tasks docs: track completion of phase 5 verification tasks - Flake evaluation: passed with zero warnings and zero assertion failures - Code style: statix, deadnix, and nixfmt clean - Build verification: home-manager generation and systemd user units verified
6aa47c6 to
ef2b0eb
Compare
1 participant
Summary
Validation
A full activation build was not completed locally because the daemon cannot trust the Noctalia cache and would fetch about 2.5 GiB.